-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 423: Add JSON-LD context dictionary generator #453
base: develop
Are you sure you want to change the base?
Conversation
References: * ucoProject#423 Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
This is the result of working through a few rounds of `mypy --strict`, which now passes when rdflib >= 6.2.0 is installed in the virtual environment. Some minor logic errors were caught. At least one significant error was found and flagged. References: * ucoProject#423 Signed-off-by: Alex Nelson <[email protected]>
References: * ucoProject#423 Signed-off-by: Alex Nelson <[email protected]>
References: * ucoProject#423 Signed-off-by: Alex Nelson <[email protected]>
Test known to fail currently. References: * ucoProject#423 Signed-off-by: Alex Nelson <[email protected]>
This is another necessary proof of functionality for the testing. References: * ucoProject#423 Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
References: * ucoProject#423 Signed-off-by: Alex Nelson <[email protected]>
@kfairbanks - I inlined a TODO that you might need to address, about keying some Your method for building the namespace prefixes looks like it would benefit from a stably-available prefix definition, rather than needing to crawl through All of the ontologies under SELECT ?nOntology ?lLabel
WHERE {
?nOntology a owl:Ontology .
OPTIONAL {
?nOntology rdfs:label ?lLabel .
}
}
ORDER BY ?nOntology Meanwhile: I've added a test for the "Concise" dictionary form. It currently fails, and reviewing the generated file, I see the issue is that classes are not being generated for either dictionary form. I was surprised that the "Minimal" JSON-LD sample was working with both the "minimal" and "concise" context dictionaries. The reason that worked was that the classes that weren't in the context dictionary were inlined in each of the nodes. I also added tests for whether UCO properties and datatype annotations (UCO-sourced and XSD-sourced) were getting picked up by the dictionaries, by adapting the The last test, which I'm not sure can be run from Next steps: Please get |
Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
Converting to Draft until Solutions Approval vote is logged. |
…dictionary I had previously realized, and forgotten, that datatyped literals do not appear to be supported as a feature within context dictionaries. References: * ucoProject#423 Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
This is to account for classes that UCO imports from external ontologies. This patch is necessary, but insufficient, to fix the thread test. Signed-off-by: Alex Nelson <[email protected]>
This Pull Request resolves all requirements of Issue #423 .
Coordination
unstable
branch (merge-commit)unstable
branch tracking UCO'sunstable
as submodule (merge-commit)