Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 373: Upgrade rdf-toolkit and Java, and move call pattern to pre-commit #386

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

ajnelson-nist
Copy link
Contributor

This Pull Request will resolve all requirements of Issue 373.

The repository version noted in this commit does not currently catch
subdirectories' Turtle files, so a follow-on patch will update the
repository pointer.

References:
* #373
@ajnelson-nist ajnelson-nist marked this pull request as draft May 26, 2022 00:58
@ajnelson-nist ajnelson-nist linked an issue May 26, 2022 that may be closed by this pull request
14 tasks
The landing page for the setup-java action states the following:

> NOTE: Adopt OpenJDK got moved to Eclipse Temurin and won't be updated
> anymore. It is highly recommended to migrate workflows from adopt to
> temurin to keep receiving software and security updates. See more
> details in the Good-bye AdoptOpenJDK post.

References:
* https://github.com/actions/setup-java/#supported-distributions
* https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/

Signed-off-by: Alex Nelson <[email protected]>
With the current version of `rdf-toolkit-action`, this is expected to
cause a CI failure due to an `rdf-toolkit.jar` incompatibility.  A
release coming soon for `rdf-toolkit-action` will update the `.jar` file
used.

Signed-off-by: Alex Nelson <[email protected]>
The version of rdf-toolkit run by the pre-commit hook now handles an RDF
list differently than the prior version of rdf-toolkit.

This commit is a mechanically-produced result.

References:
* #373

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist
Copy link
Contributor Author

This PR is now "version 1" of the resolution of Issue 373. PR 395 borrows the Java upgrade steps from this PR. Usage of pre-commit will have to await one or more upstream issues being resolved.

@ajnelson-nist ajnelson-nist removed a link to an issue Jun 1, 2022
14 tasks
@ajnelson-nist ajnelson-nist added this to the UCO 1.x.0 milestone Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant