-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 373: Upgrade rdf-toolkit and Java, and move call pattern to pre-commit #386
Draft
ajnelson-nist
wants to merge
9
commits into
develop
Choose a base branch
from
Feature-Issue-373
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The repository version noted in this commit does not currently catch subdirectories' Turtle files, so a follow-on patch will update the repository pointer. References: * #373
References: * casework/CASE-Utilities-Python#37 * #373
14 tasks
Signed-off-by: Alex Nelson <[email protected]>
The landing page for the setup-java action states the following: > NOTE: Adopt OpenJDK got moved to Eclipse Temurin and won't be updated > anymore. It is highly recommended to migrate workflows from adopt to > temurin to keep receiving software and security updates. See more > details in the Good-bye AdoptOpenJDK post. References: * https://github.com/actions/setup-java/#supported-distributions * https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/ Signed-off-by: Alex Nelson <[email protected]>
With the current version of `rdf-toolkit-action`, this is expected to cause a CI failure due to an `rdf-toolkit.jar` incompatibility. A release coming soon for `rdf-toolkit-action` will update the `.jar` file used. Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
The version of rdf-toolkit run by the pre-commit hook now handles an RDF list differently than the prior version of rdf-toolkit. This commit is a mechanically-produced result. References: * #373 Signed-off-by: Alex Nelson <[email protected]>
7 tasks
This PR is now "version 1" of the resolution of Issue 373. PR 395 borrows the Java upgrade steps from this PR. Usage of |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request will resolve all requirements of Issue 373.