Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Endurant subclass position; add and demonstrate Quality #3

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Update Endurant subclass position; add and demonstrate Quality #3

merged 1 commit into from
Feb 8, 2024

Conversation

ajnelson-nist
Copy link
Contributor

No description provided.

@ajnelson-nist
Copy link
Contributor Author

@plbt5 , for your review notes: gufo:Endurant is defined as a disjoint-union, so actual uses of drafting:Endurant need to subclass either gufo:Aspect or gufo:Object.

This first patch introduces quality, with one demonstration of a uco-types:Hash as a reified quality-value. The demonstration intentionally doesn't specialize to a subclass of Quality that focuses on hashes---yet.

I'm fine with it being merged once CI passes.

@ajnelson-nist ajnelson-nist marked this pull request as ready for review February 2, 2024 22:02
@ajnelson-nist ajnelson-nist requested a review from a team as a code owner February 2, 2024 22:02
@plbt5
Copy link
Contributor

plbt5 commented Feb 8, 2024

@ajnelson-nist Do you want me to merge it?

@ajnelson-nist
Copy link
Contributor Author

@plbt5 - yes, please.

@plbt5 plbt5 merged commit c4dad53 into main Feb 8, 2024
1 check passed
@plbt5 plbt5 deleted the add_qualities branch February 8, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plbt5 plbt5 plbt5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajnelson-nist @plbt5