check if document exists before elasticsearch get #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qjhart
requested changes
Mar 26, 2024
| * @description Remove Work/Authorship node from Expert based on jsonld | ||
| * @param {object} jsonld: work/authorship object | ||
| **/ | ||
| async remove(jsonld) { |
There was a problem hiding this comment.
@UcDust this is not completed. Can you show me the jsonld passed here ?
|
|
||
| if( !result ) return null; | ||
|
|
||
| result = await this.client.get( |
There was a problem hiding this comment.
@UcDust this call is basically replicated in this.client_get I wonder if there is a better way for these two sperate gets to be formulated.
There was a problem hiding this comment.
@qjhart I refactored that code a bit in the last commit so that it uses that client_get() function. Added a param for _source_excludes.
|
@UcDust, not sure that's the best plan, we can review on Tues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.