Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Spike #1912

Merged
merged 7 commits into from
Jun 30, 2024
Merged

Bump Spike #1912

merged 7 commits into from
Jun 30, 2024

Conversation

jerryz123
Copy link
Contributor

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are at it, can you also update the SpikeTile ISA to have zvl128b_zve64d and zicsr_zifencei_zihpm (to match Rocket) (so something like this: rv64imafdvczicsr_zifencei_zihpm_zvl128b_zve64d).

I also want these two PRs in for checkpointing: riscv-software-src/riscv-isa-sim#1715 riscv-software-src/riscv-isa-sim#1714 but I can re-bump later

@jerryz123
Copy link
Contributor Author

Rocket does not currently have Zvl/Zve, are you sure you want them in SpikeTile?

@abejgonzalez
Copy link
Contributor

Rocket does not currently have Zvl/Zve, are you sure you want them in SpikeTile?

SpikeTiles current ISA is "rv64gcv_Zfh". I don't need V, but I figured you put V in there in the past to support it for some reason.

@jerryz123
Copy link
Contributor Author

Oh right. You are right then, we should put the full isa str

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the SpikeTile fix

@abejgonzalez abejgonzalez mentioned this pull request Jun 29, 2024
16 tasks
@jerryz123 jerryz123 merged commit d64b47d into main Jun 30, 2024
55 checks passed
@jerryz123 jerryz123 deleted the bump-spike branch June 30, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants