Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable boot to tty for base image #424

Merged
merged 1 commit into from
Nov 20, 2023
Merged

fix: enable boot to tty for base image #424

merged 1 commit into from
Nov 20, 2023

Conversation

manan-gup
Copy link
Contributor

Added statement to enable automatically booting to a tty for the base image without a DE as per #187.

I hope I've added the statement at the right place. Also, I wasn't sure what the idiomatic way to check for the base image was so I used an if statement. Let me know if I need to change anything. Thanks.

Copy link
Member

@EyeCantCU EyeCantCU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic and is the proper way to go about it. Thank you so much for the contribution!

Copy link
Contributor

@akdev1l akdev1l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@castrojo castrojo added this pull request to the merge queue Nov 20, 2023
@manan-gup
Copy link
Contributor Author

Thanks to everyone for the kind and generous experience. This was my first real, though small, open source contribution. :)

Merged via the queue into ublue-os:main with commit 82ccb30 Nov 20, 2023
22 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rebasing from base-main without DE to Bazzite doesn't set the default target to graphical
4 participants