Pre dev 0.3: cleanup io & uring_async #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ming Lei <[email protected]>
Now IO buffer is managed by target code, which needn't to retrieve buffer address from libublk any more. Inside io module, it is only used for discarding registered io buffers. Also mark it as not 'inline' which is only called in slow path. Signed-off-by: Ming Lei <[email protected]>
The annotation is obsolete now, so remove them Signed-off-by: Ming Lei <[email protected]>
Signed-off-by: Ming Lei <[email protected]>
Add UblkQueue::ublk_submit_sqe_sync() so that target code can use it to submit sqe in non-async/.await code. Signed-off-by: Ming Lei <[email protected]>
No need to return anything Ok() except for 0 from tgt_init() Signed-off-by: Ming Lei <[email protected]>
Now we don't have users for manipulating q_ring directly, but there could be potential use cases, such as, changing uring flags, register files, ... So add UblkQueue::uring_op() and UblkQueue::uring_op_mut() for such purpose. Signed-off-by: Ming Lei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UblkQueue::uring_op_mut()