Skip to content

Commit

Permalink
style: close button on left side of preview modal
Browse files Browse the repository at this point in the history
  • Loading branch information
0x4007 committed Dec 4, 2023
1 parent 60bb4be commit 3fc439d
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 14 deletions.
1 change: 0 additions & 1 deletion src/home/home.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ if (cachedIssues) {
const fullIssues = fetchCachedIssuesFull();

if (!fullIssues) {

fetchIssuesFull(cachedIssues)
.then((downloaded) => {
localStorage.setItem("githubIssuesFull", JSON.stringify(downloaded));
Expand Down
6 changes: 1 addition & 5 deletions src/home/render-github-issues.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ const previewBodyInner = document.createElement("div");
previewBodyInner.classList.add("preview-body-inner");

// Assemble the preview box
previewHeader.appendChild(title);
previewHeader.appendChild(closeButton);
previewHeader.appendChild(title);
previewBody.appendChild(previewBodyInner);
previewContent.appendChild(previewHeader);
previewContent.appendChild(previewBody);
Expand Down Expand Up @@ -186,9 +186,5 @@ function previewIssue(issuePreview: GitHubIssueWithNewFlag) {

// Function to find an issue by URL
function findIssueByUrl(issues: GitHubIssueWithNewFlag[], url: string) {
console.trace({
issues,
url,
});
return issues.find((issue) => issue.html_url === url);
}
6 changes: 3 additions & 3 deletions static/style/inverted-style.css
Original file line number Diff line number Diff line change
Expand Up @@ -460,11 +460,11 @@
margin: 16px;
/* text-align: center; */
}
.preview a{
.preview a {
word-break: break-all;
}
.preview-body-inner {
width: calc( 100% - 48px);
width: calc(100% - 48px);
max-width: 640px;
overflow: scroll;
}
Expand Down Expand Up @@ -496,7 +496,7 @@
max-height: calc(100vh - 130px);
pointer-events: none;
}
.close-preview svg{
.close-preview svg {
fill: #00000080;
}
.preview.active {
Expand Down
10 changes: 5 additions & 5 deletions static/style/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -457,14 +457,14 @@
padding-left: 12px;
}
.preview h1 {
margin: 16px;
margin: 8px;
/* text-align: center; */
}
.preview a{
.preview a {
word-break: break-all;
}
.preview-body-inner {
width: calc( 100% - 48px);
width: calc(100% - 48px);
max-width: 640px;
overflow: scroll;
}
Expand Down Expand Up @@ -496,7 +496,7 @@
max-height: calc(100vh - 130px);
pointer-events: none;
}
.close-preview svg{
.close-preview svg {
fill: #ffffff80;
}
.preview.active {
Expand All @@ -507,7 +507,7 @@
.preview-header {
display: flex;
align-items: center;
justify-content: space-between;
/* justify-content: space-between; */
margin-bottom: 8px;
}

Expand Down

0 comments on commit 3fc439d

Please sign in to comment.