Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): add descriptions to JSON schema properties #49

Closed

Conversation

Keyrxng
Copy link
Contributor

@Keyrxng Keyrxng commented Nov 26, 2024

@gentlementlegen gentlementlegen self-requested a review November 29, 2024 13:23
@gentlementlegen
Copy link
Member

@Keyrxng maybe you should add examples too?

Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Keyrxng Could you:

  1. Add examples
  2. Fix code conflicts
  3. Fix prettier

@rndquu rndquu marked this pull request as draft December 4, 2024 07:59
@0x4007 0x4007 closed this Dec 19, 2024
@Keyrxng
Copy link
Contributor Author

Keyrxng commented Dec 20, 2024

This shouldn't have been closed.

#48

Can't move til this issue is resolved. I commented elsewhere that not all props need examples because the HTML input ele contains the value already.

@rndquu
Copy link
Member

rndquu commented Dec 20, 2024

Can't move til this issue is resolved

#48 is not connected with #49 (review)

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Dec 20, 2024

Can't move til this issue is resolved

#48 is not connected with #49 (review)

There is no description because it is not (at the time) used within the code base, so it is sort of related.

I can review this plugin's code and check again but my issues are being ignored so little point in that

"warningThreshold": {
        "default": 0.75,
        "description": "",
        "type": "number"
      },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants