-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config): add descriptions to JSON schema properties #49
fix(config): add descriptions to JSON schema properties #49
Conversation
@Keyrxng maybe you should add examples too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Keyrxng Could you:
- Add examples
- Fix code conflicts
- Fix prettier
This shouldn't have been closed. Can't move til this issue is resolved. I commented elsewhere that not all props need examples because the HTML input ele contains the value already. |
#48 is not connected with #49 (review) |
There is no description because it is not (at the time) used within the code base, so it is sort of related. I can review this plugin's code and check again but my issues are being ignored so little point in that "warningThreshold": {
"default": 0.75,
"description": "",
"type": "number"
}, |
Relates to ubiquity-os/ubiquity-os-plugin-installer#24