fix: SDK usage #50
Merged
fix: SDK usage #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces `Context` with `ContextPlugin` in multiple files to utilize standardized context structure.
Unused files (1)
|
Added ESM support in Jest and package.json, updated moduleResolution in tsconfig.
Deleted `validator.ts`, removed unused dependencies, and updated the test script in `package.json`.
Update the URL in the fetch call and modify the expected response status and `ok` flag.
Updated `stateId` in `issue-comment-post.json
Enhanced plugin setup by adding fetch handler to handle requests
|
@whilefoo Please little help, I can't get the signature to work within the tests. What am I doing wrong? |
Simplify type import for ExecutionContext from 'hono' package.
Added Hono framework version 4.6.7 to project dependencies in package.json and updated yarn.lock.
0x4007
reviewed
Oct 28, 2024
Updated wrangler settings, updated to latest package versions.
Updated environment variable references and tests for consistency.
|
Apologies I am an imbecile, remembered that we renamed |
I was looking at the code right as you changed to |
0x4007
approved these changes
Oct 28, 2024
Replaces `Context` with `ContextPlugin` in multiple files to utilize standardized context structure.
Added ESM support in Jest and package.json, updated moduleResolution in tsconfig.
Deleted `validator.ts`, removed unused dependencies, and updated the test script in `package.json`.
Update the URL in the fetch call and modify the expected response status and `ok` flag.
Updated `stateId` in `issue-comment-post.json
Enhanced plugin setup by adding fetch handler to handle requests
Simplify type import for ExecutionContext from 'hono' package.
Added Hono framework version 4.6.7 to project dependencies in package.json and updated yarn.lock.
Updated wrangler settings, updated to latest package versions.
Updated environment variable references and tests for consistency.
|
@0x4007 I will fix the merges and update, should take me ~1h more sorry. |
Updated various files to replace the Context type with ContextPlugin.
# Conflicts: # .cspell.json # src/handlers/pricing-label.ts # src/handlers/sync-labels-to-config.ts # src/run.ts # src/shared/issue.ts # src/shared/label.ts # src/shared/pricing.ts # src/types/plugin-input.ts # src/types/typeguards.ts # tests/__mocks__/handlers.ts # tests/main.test.ts # yarn.lock
Deleted unused handler and cleaned up cspell settings.
gentlementlegen
merged commit eb5b16e
into
ubiquity-os-marketplace:development
2 checks passed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #47