Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to Go 1.20 #72

Merged
merged 28 commits into from
Aug 29, 2024
Merged

chore: upgrade to Go 1.20 #72

merged 28 commits into from
Aug 29, 2024

Conversation

mojixcoder
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Aug 26, 2024

Pull Request Test Coverage Report for Build 10606327296

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.986%

Totals Coverage Status
Change from base Build 10562760044: 0.0%
Covered Lines: 550
Relevant Lines: 573

💛 - Coveralls

@mojixcoder mojixcoder changed the title chore: upgrade to Go 1.22 chore: upgrade to Go 1.20 Aug 26, 2024
jogly
jogly previously approved these changes Aug 28, 2024
Copy link
Collaborator

@jogly jogly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jogly
Copy link
Collaborator

jogly commented Aug 28, 2024

could you also upgrade golangci lint to a recent version that works with 1.20+?

isaacbrodsky
isaacbrodsky previously approved these changes Aug 28, 2024
isaacbrodsky
isaacbrodsky previously approved these changes Aug 28, 2024
@mojixcoder
Copy link
Contributor Author

After running lints locally, it should return success status code now.

@mojixcoder
Copy link
Contributor Author

Removed linters are the ones that either got removed or replaced by other linters in the golangci new versions.

@jogly jogly merged commit 1ce71fc into uber:master Aug 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants