Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes regarding winning/losing #128

Merged
merged 6 commits into from
Apr 4, 2020
Merged

Various fixes regarding winning/losing #128

merged 6 commits into from
Apr 4, 2020

Conversation

chuck-sys
Copy link
Contributor

🚢 Pull Request

❓ Purpose

Give a brief description of your changes: A bunch of fixes regarding winning and losing.

  • Weeks no longer pass during follow-up events
  • Faculty selection and resident selection do not take 2 weeks, but 1 only
  • Button appears at the end of the game that refreshes the page when pressed to allow replay

🔨 Validation Strategy

Describe how you verified your changes (if applicable): Played the thing a bunch of times.

🎟️ Ticket(s)

Closes #123

@chuck-sys chuck-sys added this to the Term 2 milestone Mar 31, 2020
@chuck-sys chuck-sys requested a review from a team as a code owner March 31, 2020 04:46
@chuck-sys chuck-sys changed the title [WIP] Various fixes regarding winning/losing Various fixes regarding winning/losing Mar 31, 2020
rmcreyes
rmcreyes previously approved these changes Apr 1, 2020
@chuck-sys chuck-sys merged commit 88898d1 into master Apr 4, 2020
@chuck-sys chuck-sys deleted the winlose branch April 4, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Win/Losing should be at the end.
3 participants