Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Win/Losing should be at the end. #123

Closed
chuck-sys opened this issue Mar 28, 2020 · 2 comments · Fixed by #128
Closed

Win/Losing should be at the end. #123

chuck-sys opened this issue Mar 28, 2020 · 2 comments · Fixed by #128
Assignees
@chuck-sys @vitachan
Labels
bug Something isn't working dev type type type
Milestone
Term 2

Comments

@chuck-sys
Copy link
Contributor

chuck-sys commented Mar 28, 2020 •
edited
Loading

Describe the bug
Winning and losing should only happen at the end of the game. You shouldn't be able to lose and not come back from it.

We also want to have a button that refreshes the page when the game ends.

Weeks also shouldn't pass in the middle of conversations.
@chuck-sys chuck-sys added bug Something isn't working dev type type type labels Mar 28, 2020
@chuck-sys chuck-sys added this to the Term 2 milestone Mar 28, 2020
@itstonywu
Copy link
Contributor

The progress bar also needs to know the total number of weeks. It is currently hardcoded to 5 or whatever weeks. If there is a way to determine that from the JSON that would be great.

@chuck-sys
Copy link
Contributor Author

Got it. Will be adding a constant somewhere.

@chuck-sys chuck-sys mentioned this issue Mar 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chuck-sys chuck-sys

@vitachan vitachan

Labels
bug Something isn't working dev type type type
Projects
None yet
Milestone
Term 2
Development

Successfully merging a pull request may close this issue.

Various fixes regarding winning/losing ubclaunchpad/ubcsim2
3 participants
@chuck-sys @itstonywu @vitachan