Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require admin authorization on registrations getAll #420

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

voctory
Copy link
Member

@voctory voctory commented Jan 2, 2025

Changes

  • Add Cognito authorization to /registrations GET endpoint for case where we get all registrations for an event

Notes

  • Message Victor for change justification
  • This change breaks the Companion's use of the /registrations GET endpoint - follow-up PR on this repo will add API endpoints for Companion use
  • This change breaks bt-web-v2's Registration table because of permission errors - follow-up PR on bt-web-v2 will fix this

Testing

Changes work on bt-web Admin registration table, not expected to break other Registrations microservice endpoints

Copy link
Contributor

@kevinxiao27 kevinxiao27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Was the registration endpoint used for anything not gated? I agree that there should probably be auth required given the nature of the data we're fetching.

@voctory
Copy link
Member Author

voctory commented Jan 6, 2025

Answered offline

Will merge in this PR after we get the Companion Registration service up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants