Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle nodes without coordinates #143

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from
Open

Handle nodes without coordinates #143

wants to merge 3 commits into from

Commits on Dec 5, 2023

  1. Add test cases for nodes without coordinates

    @jleedev
    jleedev committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    b432abe View commit details
    Browse the repository at this point in the history

  2. Handle nodes without coordinates 

    Treat nodes without coordinates the same as if they are absent, in
construct_multipolygon, construct_multilinestring, and when processing
ways, to avoid producing coordinates of NaN/null.

When a segment of a relation (either a line string, or a polygon ring)
consists entirely of invalid nodes, omit this empty array, to avoid
producing a coordinates element which is an empty array.

Both of these changes will cause such features to be omitted from the
output when they have no coordinates, just as they already are for ways
which reference nodes that are absent, and relations which reference
ways that are absent.
    @jleedev
    jleedev committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    07f3e43 View commit details
    Browse the repository at this point in the history

  3. run make

    @jleedev
    jleedev committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    123b1c6 View commit details
    Browse the repository at this point in the history