Make debug logging of typesense imports expicit and configurable #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his standardizes logging across both .onWrite and .backfill, and allows disabling logging for production builds and improved data privacy. Option can be turned off an off in firebase extension config using LOG_TYPESENSE_INSERTS
…t-3 and test-part-4
Merged
1 task
|
@jasonbosco something i need to do to get tests running? Thanks |
jasonbosco
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Standardize debug logging for typesense inserts and make this configurable in extension settings. For debugging purposes its good to log inserts, but added support to disable this for production environments.
To better support testing, created a node based test environment runner that can setup firebase environment and run the emulator. This approach also helps streamline testing in package.json and reduce boiler template in test cases. This also allows test case to verify server logs.
PR Checklist