Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abg): make pair building pretty again #1618

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

Vampire
Copy link
Collaborator

@Vampire Vampire commented Aug 21, 2024

No description provided.

@krzema12 krzema12 changed the title fix(abg): Make pair building pretty again fix(abg): make pair building pretty again Aug 22, 2024
@krzema12
Copy link
Member

It effectively reverts #1607 - are you sure that the problems you were having with Kotlin Poet won't come back? Maybe you recall how we could reproduce the problems? If in doubt, we can leave the uglier code just in case.

@Vampire
Copy link
Collaborator Author

Vampire commented Aug 22, 2024

Just almost :-)
And yes I tested with the exact case that failed previously.
Now there are not spaces around the to but mid-dots which tell the poet to put spaces there but not break on those.
If you replace the mid-dots with spaces again, the compile error is back.

@krzema12
Copy link
Member

Oh OK, so like a non-breaking space. Clever!

@krzema12 krzema12 merged commit 42cd19f into main Aug 22, 2024
18 checks passed
@krzema12 krzema12 deleted the vampire/make-pair-building-pretty-again branch August 22, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants