-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource makeFull #1493
Merged
Merged
Resource makeFull #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although there are a few open questions, I think this is ready for an initial review.
The most relevant files are
Resource
,Semaphore
, and the relative tests.Summary of the changes:
Resource
is invariant inF
Allocate
,Eval
,Pure
,Bind
bracketFull
which allowed interruptible releasesliftF
is deprecated in favour ofeval
Semaphore
has a new implementation. Hopefully it's clearer, although the underlying idea remains complex (necessarily so)Open questions:
This appears to work.Resource.mapK
requires aMonadCancel[F, Throwable]
on both source and destination effects, which is problematic forSemaphore
, which currently only takes aGenConcurrent[F, _]
. I've tried quite a few things, one thing still left to try though is havingmapK
takeMonadCancel[F, _]
andMonadCancel[G, _]
, and see how that goes (skeptical, but we'll see).I think that as constructed, allowFull can be engineered to build a Resource with interruptible release (makeFull cannot). Not quite sure if we want to tackle that, or just say "don't do that".Fixed inbracketFull
.liftK
with the current name, rather thanevalK
, since consistency with cats for that sort of operation seems more important (whereas forliftF/eval
, consistency with fs2 is). Let me know if you have a different view, andevalK
should be introduced instead.