Cleanup of URL-SelectDirectories.swift #136
Open
+30
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vdhamer
commented
Oct 12, 2024
•
vdhamer
commented
- Cleanup of URL-SelectDirectories (Fix: PublishingContext.copyResources() fails when Ignite included as a package #135)
- SwiftLint 0.57.0 gives errors. See
- optional_string_data_conversion
- https://www.hackingwithswift.com/example-code/language/how-to-convert-data-to-a-string
Optional Data -> String Conversion Violation: Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion) Discussion on this: realm/SwiftLint#5785
No functional changes. Added more documentation.
vdhamer
changed the title
Quite a struggle to have the FetchRequest depend on a passed parameter, but used Paul Hudson's trick of saving the query and not its result. Also some code restructuring.
Was givenName only, and thus didn't match SwiftUI equivalent in UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.