fix: race condition in tests #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makefile
Outdated
| go test -race -count=1 `go list ./... | grep -v e2e-tests` | ||
|
|
||
| .PHONY: unit-tests-ci | ||
| unit-tests-ci: ## run unit tests without e2e-tests directory (multiple times to find race conditions). | ||
| go test -race -count=50 `go list ./... | grep -v e2e-tests` |
There was a problem hiding this comment.
You can pass failfast flag also
| @@ -54,10 +54,11 @@ func TestCreateRemoveConcurrently(t *testing.T) { | |||
| hubs := &sync.Map{} | |||
|
|
|||
| wg := sync.WaitGroup{} | |||
| wg.Add(channelsNo * clientsPerChannel) | |||
| wg.Add(channelsNo*clientsPerChannel + channelsNo) | |||
There was a problem hiding this comment.
Caan you explain why this logic? Preferably in comment in code.
There was a problem hiding this comment.
Explained in comment
krzysztofdrys
force-pushed
the
feat/fix-race-condition-in-tests
branch
from
808b2ad
to
5be1ef5
Compare
krzysztofdrys
force-pushed
the
feat/fix-race-condition-in-tests
branch
from
5be1ef5
to
fab72d4
Compare
tobiaszheller
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.