-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add Scala 3 to CI matrix #308
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #308 +/- ##
========================================
Coverage 49.11% 49.12%
========================================
Files 320 320
Lines 18459 18459
Branches 1074 1074
========================================
+ Hits 9067 9068 +1
+ Misses 9392 9391 -1
Continue to review full report at Codecov.
|
Ok, so apart from the usual flaky test in I've downgraded sbt-scoverage to I'm rebasing this onto develop to make it ready for merging, even if it means the CI will be red on this PR in the meantime. 🙂 |
a15bd27
to
c8f2c66
Compare
@felixbr, do you mind rebasing on master to get the scoverage fix pulled in and presumably turn the CI checks green? |
c8f2c66
to
92b8e73
Compare
@bryce-anderson There you go. The one failing test is the usual flaky one in util-app. I'd recommend setting its timeout much higher because it's really annoying that PRs are red all the time because of it. It's waiting for an interrupt but CI is too slow so instead it throws a timeout:
|
92b8e73
to
e42dbe2
Compare
e42dbe2
to
eb9d2f6
Compare
I rebased the PR onto |
I rebased the PR onto The two failed runs are the usual flaky test in |
Several people have worked on Scala 3 support of various modules, which is great.
Scala 3 support currently isn't part of CI, which means it is only validated locally by the person currently working on it. This causes already working cross-builds to break by accident (e.g. when updating versions).
To avoid this and make working on Scala 3 more efficient I'm trying to setup at least basic CI for it.
Coverage is currently not really working with Scala 3.0.2, so I'm trying to ignore it for Scala 3 only.