Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Node 16 as runner, update dependencies #203

Merged
merged 8 commits into from
Sep 19, 2022

Conversation

MattIPv4
Copy link
Member

@MattIPv4 MattIPv4 commented Sep 18, 2022

Resolves #196

Updates the repo + all workflows to use Node.js 16, switching the workflows over to using the .nvmrc file in the repo as the source of truth for the Node.js version to run. The distributed action.yml is hard-coded to use Node.js 16 as GitHub does not support using .nvmrc there to determine the runtime.

Updates all outdated dependencies in the repository, including nock/tap updates that were needed to allow the tests to function in Node.js, and parse-diff which highlighted some invalid diffs in the test suite that needed fixing.

@MattIPv4
Copy link
Member Author

@gr2m Potentially unrelated to this PR, but I thought I'd ask here -- is the expectation that PRs do include updated versions of dist/index.js, or should there be automation that handles that when a new release is created?

@MattIPv4
Copy link
Member Author

(I've updated the PR body here to indicate this is a breaking change in that the required Node.js version is being bumped, which is breaking for the project... but I'm not sure it's actually a breaking change for the action, as the action itself defines what Node.js version to run and so end-users wouldn't need to make any changes unless I'm misunderstanding the action flow?)

@gr2m
Copy link
Contributor

gr2m commented Sep 19, 2022

is the expectation that PRs do include updated versions of dist/index.js, or should there be automation that handles that when a new release is created?

This repository is setup to create and push the dist/index.js file after each release to the v2 branch. It's not an ideal setup, because folks cannot use the action for any commit, there is no way to revert. I have a better solution in more recent actions I've built, I'll file an issue to change it.

I'm not sure it's actually a breaking change for the action

I don't think it is. We can release it as a fix though to see if it has any impact, and make it easier to revert if needed

@gr2m gr2m changed the title chore: Update Node.js + dependencies fix: use Node 16 as runner, update dependencies Sep 19, 2022
@gr2m gr2m merged commit 419c4fb into main Sep 19, 2022
@gr2m gr2m deleted the MattIPv4/update-dependencies branch September 19, 2022 21:02
@gr2m
Copy link
Contributor

gr2m commented Sep 19, 2022

🎉 This PR is included in version 2.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@gr2m gr2m added the released label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Node.js LTS
2 participants