-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use Node 16 as runner, update dependencies #203
Conversation
@gr2m Potentially unrelated to this PR, but I thought I'd ask here -- is the expectation that PRs do include updated versions of |
(I've updated the PR body here to indicate this is a breaking change in that the required Node.js version is being bumped, which is breaking for the project... but I'm not sure it's actually a breaking change for the action, as the action itself defines what Node.js version to run and so end-users wouldn't need to make any changes unless I'm misunderstanding the action flow?) |
This repository is setup to create and push the
I don't think it is. We can release it as a fix though to see if it has any impact, and make it easier to revert if needed |
🎉 This PR is included in version 2.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Resolves #196
Updates the repo + all workflows to use Node.js 16, switching the workflows over to using the
.nvmrc
file in the repo as the source of truth for the Node.js version to run. The distributedaction.yml
is hard-coded to use Node.js 16 as GitHub does not support using.nvmrc
there to determine the runtime.Updates all outdated dependencies in the repository, including
nock/tap
updates that were needed to allow the tests to function in Node.js, andparse-diff
which highlighted some invalid diffs in the test suite that needed fixing.