Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node.js LTS #196

Closed
MattIPv4 opened this issue Sep 10, 2022 · 4 comments · Fixed by #203
Closed

Update to Node.js LTS #196

MattIPv4 opened this issue Sep 10, 2022 · 4 comments · Fixed by #203
Labels
feature New feature or request released

Comments

@MattIPv4
Copy link
Member

What’s missing?

The project should be running on the latest LTS release of Node.js.

Why?

The project currently runs on Node.js 12 which was EOL'ed as of April this year.

Alternatives you tried

N/A

@MattIPv4 MattIPv4 added the feature New feature or request label Sep 10, 2022
@gr2m
Copy link
Contributor

gr2m commented Sep 10, 2022

Agree, I just did it on a ton of repositories using https://github.com/gr2m/octoherd-script-bump-node-version-in-workflows, setting --node-version "lts/*", but not yet on my personal account. Doing it right now

@gr2m
Copy link
Contributor

gr2m commented Sep 10, 2022

actually nevermind, I miss understood. I bump the used node versions in CI via gr2m/twitter-together@f7123bb, but your issue is about bundling the action code itself, right?

runs.using in action.yml can now be set to nod16 as per https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#example-using-nodejs-v16, do you want to send a pull request?

@MattIPv4
Copy link
Member Author

MattIPv4 commented Sep 10, 2022

It's a bit of both -- updating the action to use Node 16, but also updating the repo to it (setting an .nvmrc file for it [I'm introducing it at v12 in #177], and updating to lockfile v2)

@gr2m
Copy link
Contributor

gr2m commented Sep 19, 2022

🎉 This issue has been resolved in version 2.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@gr2m gr2m added the released label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants