Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Connection pool is full, discarding connection #716

Merged
merged 4 commits into from
Apr 22, 2024
Merged

fix: Connection pool is full, discarding connection #716

merged 4 commits into from
Apr 22, 2024

Conversation

lightiverson
Copy link
Contributor

Fixes #714

Allows for more connections when using multi-threading. By increasing max number of connections in the pool.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@tiwarishubham635 tiwarishubham635 added the status: work in progress Twilio or the community is in the process of implementing label Apr 4, 2024
tiwarishubham635
tiwarishubham635 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increasing the pool size from default 10 to at most 32. LGTM!

@tiwarishubham635 tiwarishubham635 merged commit 4ed7fec into twilio:main Apr 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiwarishubham635 tiwarishubham635 tiwarishubham635 approved these changes

Assignees
No one assigned
Labels
status: work in progress Twilio or the community is in the process of implementing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WARNING: Connection pool is full
2 participants
@lightiverson @tiwarishubham635