feat: Docs update to use custom clients when endpoints have no auth/bearer token auth and Support for PUT method #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsabuHere
changed the title
sbansla
reviewed
Jun 24, 2024
| @@ -140,7 +140,7 @@ public <T extends IRequest> Response makeRequest(final T request) { | |||
| } | |||
| } | |||
|
|
|||
| if (method == HttpMethod.POST) { | |||
| if (method == HttpMethod.POST || method == HttpMethod.PUT) { | |||
There was a problem hiding this comment.
GET does not have body all other methods can have body.
Check with Shubham before adding Delete support.
There was a problem hiding this comment.
checked with Shubham
Adding support for all methods except GET
sbansla
reviewed
Jun 24, 2024
README.md
Outdated
| private static final String CLIENT_SECRET = "client_secret_of_organization"; | ||
|
|
||
| public static void main(String[] args) throws AuthenticationException { | ||
| TwilioOrgsTokenAuth.setTokenManager(new CustomTokenManagerImpl(GRANT_TYPE, CLIENT_SID, CLIENT_SECRET)); |
There was a problem hiding this comment.
Add this in example and give link. Lets keep readme more readable and concise.
Also give example without custom token manager.
There was a problem hiding this comment.
This change was added in main, check there as well.
We did not add delete because it was giving some error(I think), but now we can add delete as well.
sbansla
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
A short description of what this PR does.
Docs update to use custom clients when endpoints have no auth/bearer token auth and Support for PUT method
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.