Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: make Twilio not singleton #675

Closed
wants to merge 40 commits into from
Closed

feat!: make Twilio not singleton #675

wants to merge 40 commits into from

Commits on Mar 4, 2022

  1. docs: add unfinished report to repo (#2)

    @emilmyresten
    emilmyresten committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    f742ad7 View commit details
    Browse the repository at this point in the history

  2. docs: change report to correct one (#2)

    @emilmyresten
    emilmyresten committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    5d0ee1f View commit details
    Browse the repository at this point in the history

  3. Branch/emil into main (#6) 

    * feat: twilio implements twilioapi, changed usage examples

* feat: change initialization of all tests (#3)

* refactor: moved static block in twilio.java (#5)

* refactor: changed this to static methods (#5)

* feat: twilio class and interface final (#1 #5)

* refactor: change synchronized back to original version (#3)
    @emilmyresten
    emilmyresten authored Mar 4, 2022
    Configuration menu
    Copy the full SHA
    5ec80d1 View commit details
    Browse the repository at this point in the history

  4. merge: pr #14, creator now takes object reference instead of static m… 

    …ethod (#7)

* git: update gitignore

* feat: updated creator abstract methods to take Twilio object (#7)

* fix: update examples to use twilio object as argument in create-method (#7)
    @emilmyresten
    emilmyresten authored Mar 4, 2022
    Configuration menu
    Copy the full SHA
    33d7dc3 View commit details
    Browse the repository at this point in the history

  5. merge: PR #15 update usage of .create() to .create(tw) in all tests 

    * test: replace .create() with .create(tw) to conform to new usage (#7)

Fixes #7
    @emilmyresten
    emilmyresten authored Mar 4, 2022
    Configuration menu
    Copy the full SHA
    ab2861a View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2022

  1. merge: PR #16, feat: update Updater to take in Twilio (#13) 

    Fixes #13
    @SimonOsnes
    SimonOsnes authored Mar 5, 2022
    Configuration menu
    Copy the full SHA
    41c4ff9 View commit details
    Browse the repository at this point in the history

  2. merge: PR #18: fix bug in .setUsername method (#17) 

    * fix: bug in setUsername method (#17)
    @emilmyresten
    emilmyresten authored Mar 5, 2022
    Configuration menu
    Copy the full SHA
    9f0651f View commit details
    Browse the repository at this point in the history

  3. test: add multitenancy test and cleanup testclass (#19)

    @emilmyresten
    emilmyresten committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    e9f1b4e View commit details
    Browse the repository at this point in the history

  4. merge: PR #21, test: change all occurences of .update() to .update(tw… 

    …) in tests (#21)

* test: update new method call .update() to .update(tw) (#13)
    @SimonOsnes
    SimonOsnes authored Mar 5, 2022
    Configuration menu
    Copy the full SHA
    3e40e09 View commit details
    Browse the repository at this point in the history

  5. feat: update Fetcher method update() to update(Twilio) #11

    @ViktorAryd
    ViktorAryd committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    c40893c View commit details
    Browse the repository at this point in the history

  6. test: change tests to use updated method call update(Twilio) #11

    @ViktorAryd
    ViktorAryd committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    6192b3a View commit details
    Browse the repository at this point in the history

  7. merge: PR #20 add multitenancy test and cleanup TwilioTest.java (#19)

    @SimonOsnes
    SimonOsnes authored Mar 5, 2022
    Configuration menu
    Copy the full SHA
    ff07500 View commit details
    Browse the repository at this point in the history

  8. merge: PR #22 

    feat: update Fetcher class methods to take Twilio object and changes tests accordingly (#11)
    @SimonOsnes
    SimonOsnes authored Mar 5, 2022
    Configuration menu
    Copy the full SHA
    f9f5dc0 View commit details
    Browse the repository at this point in the history

  9. UML diagram added to report-group8.md (#2)

    @emilmyresten
    emilmyresten authored Mar 5, 2022
    Configuration menu
    Copy the full SHA
    b5d101a View commit details
    Browse the repository at this point in the history

  10. docs: add UML-before refactoring to report (#2)

    @emilmyresten
    emilmyresten authored Mar 5, 2022
    Configuration menu
    Copy the full SHA
    06715bf View commit details
    Browse the repository at this point in the history

  11. feat: updates Deleter to take in non-singleton twilio instance (#8)

    @joakim-olsson
    joakim-olsson committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    dd1eb0c View commit details
    Browse the repository at this point in the history

  12. test: update new method call signature to take in instance of twilio (#8 

    )
    @joakim-olsson
    joakim-olsson committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    158fd06 View commit details
    Browse the repository at this point in the history

  13. docs: adds essence to repo report (#2) 

    docs: adds essence to repo report (#2)
    @joakim-olsson
    joakim-olsson authored Mar 5, 2022
    Configuration menu
    Copy the full SHA
    a05cf77 View commit details
    Browse the repository at this point in the history

  14. merge: PR #24: update Delete to take in Twilio (#8)

    @joakim-olsson
    joakim-olsson authored Mar 5, 2022
    Configuration menu
    Copy the full SHA
    3559638 View commit details
    Browse the repository at this point in the history

  15. feat: update methods in Reader and CallReaderExample to take in Twili… 

    …o tw object. (#11)
    @jovaanchan
    jovaanchan committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    ecb5421 View commit details
    Browse the repository at this point in the history

  16. test: change read tests to use Twilio instance (#11)

    @jovaanchan
    jovaanchan committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    8af7acc View commit details
    Browse the repository at this point in the history

  17. fix: renamed two testmethods that had been renamed faulty in refactor (… 

    …#13)
    @emilmyresten
    emilmyresten committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    bc0d329 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2022

  1. test: remove @mocked for twilio class in tests (#23)

    @SimonOsnes
    SimonOsnes committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    b90e615 View commit details
    Browse the repository at this point in the history

  2. chore: add logs before and after patch

    @SimonOsnes
    SimonOsnes committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    f38ff24 View commit details
    Browse the repository at this point in the history

  3. docs: update javadocs where method params changed (#25)

    @SimonOsnes
    SimonOsnes committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    75b368c View commit details
    Browse the repository at this point in the history

  4. docs: git diff, overall experience, emils time(#2)

    @emilmyresten
    emilmyresten authored Mar 6, 2022
    Configuration menu
    Copy the full SHA
    de96212 View commit details
    Browse the repository at this point in the history

  5. docs: update README.md to not use .init()

    @SimonOsnes
    SimonOsnes committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    ae8a731 View commit details
    Browse the repository at this point in the history

  6. merge: solving merge conflict

    @SimonOsnes
    SimonOsnes committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    739f3eb View commit details
    Browse the repository at this point in the history

  7. docs: adds design pattern discussion to repo report (#2)

    @joakim-olsson
    joakim-olsson authored Mar 6, 2022
    Configuration menu
    Copy the full SHA
    64db532 View commit details
    Browse the repository at this point in the history

  8. test: adds additional RequestValidator test cases

    @joakim-olsson
    joakim-olsson committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    e7c3192 View commit details
    Browse the repository at this point in the history

  9. merge: adds additional RequestValidator test cases 

    test: adds additional RequestValidator test cases
    @joakim-olsson
    joakim-olsson authored Mar 6, 2022
    Configuration menu
    Copy the full SHA
    1be3fbf View commit details
    Browse the repository at this point in the history

  10. docs: Joakim effort spent (#2)

    @joakim-olsson
    joakim-olsson authored Mar 6, 2022
    Configuration menu
    Copy the full SHA
    613eba9 View commit details
    Browse the repository at this point in the history

  11. docs: changed wrong effort spent (#2)

    @joakim-olsson
    joakim-olsson authored Mar 6, 2022
    Configuration menu
    Copy the full SHA
    c21efd8 View commit details
    Browse the repository at this point in the history

  12. docs: add time spent to report (#2)

    @ViktorAryd
    ViktorAryd committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    f3b1b11 View commit details
    Browse the repository at this point in the history

  13. docs: change some section of report, mostly looked ok (#2)

    @ViktorAryd
    ViktorAryd committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    4870932 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. docs: add time spent to report (#2)

    @jovaanchan
    jovaanchan authored Mar 7, 2022
    Configuration menu
    Copy the full SHA
    63b07b6 View commit details
    Browse the repository at this point in the history

  2. docs: add mention of where to find test logs

    @ViktorAryd
    ViktorAryd authored Mar 7, 2022
    Configuration menu
    Copy the full SHA
    33bccd9 View commit details
    Browse the repository at this point in the history

  3. docs: add effort spent for Simon (#2)

    @SimonOsnes
    SimonOsnes authored Mar 7, 2022
    Configuration menu
    Copy the full SHA
    a539133 View commit details
    Browse the repository at this point in the history

  4. docs: update report after presentation (#2)

    @SimonOsnes
    SimonOsnes authored Mar 7, 2022
    Configuration menu
    Copy the full SHA
    834aea3 View commit details
    Browse the repository at this point in the history

  5. chore: clean patch for PR

    @SimonOsnes
    SimonOsnes committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    0634d45 View commit details
    Browse the repository at this point in the history