Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process: fix tests #17

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Process: fix tests #17

merged 2 commits into from
Dec 13, 2022

Conversation

qaristote
Copy link
Contributor

This PR fixes the bug described in #15.

It does so by removing the (exit) commands at the end of sources, replacing them with (get-info :name) so that the ackCommands are still evaluated by the solver even in lazy mode.

this command stops the solver processes, making any code trying to close the process afterwardsfail
to ensure all the commands are sent in lazy mode, we add a dummy (get-info :name) command at the end of sources instead
Copy link
Member

@facundominguez facundominguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qaristote qaristote merged commit 3247355 into master Dec 13, 2022
@qaristote qaristote deleted the qa/tests_fix_exits branch December 13, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants