Merge pull request #40 from tweag/qa/hlint

apply hlint suggestions
tweag · Jan 10, 2023 · 5179a35 · 5179a35
2 parents e3d0083 + de246d3
commit 5179a35
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/smtlib-backends-process/src/SMTLIB/Backends/Process.hs b/smtlib-backends-process/src/SMTLIB/Backends/Process.hs
@@ -1,7 +1,6 @@
+{-# LANGUAGE DisambiguateRecordFields #-}
 {-# LANGUAGE OverloadedStrings #-}
-{-# LANGUAGE PatternGuards #-}
 {-# LANGUAGE PatternSynonyms #-}
-{-# LANGUAGE RecordWildCards #-}
 {-# LANGUAGE ViewPatterns #-}
 
 -- | A module providing a backend that launches solvers as external processes.
@@ -105,7 +104,7 @@ new config = do
             IO.hClose h `X.catch` \ex ->
               reportError' $ BS.pack $ show (ex :: X.IOException)
           )
-    reportError' = (reportError config) . LBS.fromStrict
+    reportError' = reportError config . LBS.fromStrict
 
 -- | Wait for the process to exit and cleanup its resources.
 wait :: Handle -> IO ExitCode

diff --git a/smtlib-backends-z3/src/SMTLIB/Backends/Z3.hs b/smtlib-backends-z3/src/SMTLIB/Backends/Z3.hs
@@ -50,7 +50,7 @@ C.context
   )
 C.include "z3.h"
 
-data Config = Config
+newtype Config = Config
   { -- | A list of options to set during the solver's initialization.
     -- Each pair is of the form @(paramId, paramValue)@, e.g.
     -- @(":produce-models", "true")@.
@@ -61,7 +61,7 @@ data Config = Config
 instance Default Config where
   def = Config []
 
-data Handle = Handle
+newtype Handle = Handle
   { -- | A black-box representing the internal state of the solver.
     context :: ForeignPtr Z3Context
   }

diff --git a/smtlib-backends-z3/tests/Main.hs b/smtlib-backends-z3/tests/Main.hs
@@ -12,7 +12,8 @@ import Test.Tasty.HUnit
 main :: IO ()
 main = do
   defaultMain $
-    testGroup "Tests" $
+    testGroup
+      "Tests"
       [ testBackend "Basic examples" validSources z3,
         testGroup "API usage examples" examples,
         testBackend "Error handling" failingSources z3

diff --git a/src/SMTLIB/Backends.hs b/src/SMTLIB/Backends.hs
@@ -1,4 +1,5 @@
 {-# LANGUAGE OverloadedStrings #-}
+{-# LANGUAGE TupleSections #-}
 
 module SMTLIB.Backends
   ( Backend (..),
@@ -19,7 +20,7 @@ import Prelude hiding (log)
 
 -- | The type of solver backends. SMTLib2 commands are sent to a backend which
 -- processes them and outputs the solver's response.
-data Backend = Backend
+newtype Backend = Backend
   { -- | Send a command to the backend.
     send :: Builder -> IO LBS.ByteString
   }
@@ -39,8 +40,7 @@ putQueue q cmd = atomicModifyIORef q $ \cmds ->
 -- | Empty the queue of commands to evaluate and return its content as a bytestring
 -- builder.
 flushQueue :: Queue -> IO Builder
-flushQueue q = atomicModifyIORef q $ \cmds ->
-  (mempty, cmds)
+flushQueue q = atomicModifyIORef q (mempty,)
 
 -- | A solver is essentially a wrapper around a solver backend. It also comes with
 -- a function for logging the solver's activity, and an optional queue of commands
@@ -107,7 +107,7 @@ command :: Solver -> Builder -> IO LBS.ByteString
 command solver cmd = do
   send (backend solver)
     =<< case queue solver of
-      Nothing -> return $ cmd
+      Nothing -> return cmd
       Just q -> (<> cmd) <$> flushQueue q
 
 -- | A command with no interesting result.