Migrate phpunit metadata to attributes

tvdijen · Apr 30, 2024 · 392546c · 392546c · tvdijen · May 1, 2024
1 parent 82a5736
commit 392546c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/tests/src/Controller/OTPTest.php b/tests/src/Controller/OTPTest.php
@@ -6,6 +6,7 @@
 
 use DateTimeImmutable;
 use DateTimeInterface;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\TestCase;
 use RuntimeException;
 use SimpleSAML\{Auth, Configuration, Error, Logger, Session, Utils};
@@ -15,9 +16,8 @@
 
 /**
  * Set of tests for the controllers in the "cmdotcom" module.
- *
- * @covers \SimpleSAML\Module\cmdotcom\Controller\OTP
  */
+#[CoversClass(Controller\OTP::class)]
 class OTPTest extends TestCase
 {
     /** @var string|null */

diff --git a/tests/src/Utils/PhoneNumberTest.php b/tests/src/Utils/PhoneNumberTest.php
@@ -5,14 +5,15 @@
 namespace SimpleSAML\Test\Module\cmdotcom\Utils;
 
 use libphonenumber\NumberParseException;
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 use SimpleSAML\Module\cmdotcom\Utils\PhoneNumber as PhoneNumberUtils;
 
 /**
  * Set of tests for the PhoneNumber utilities in the "cmdotcom" module.
- *
- * @covers \SimpleSAML\Module\cmdotcom\Utils\PhoneNumber
  */
+#[CoversClass(PhoneNumberUtils::class)]
 class PhoneNumberTest extends TestCase
 {
     /** @var \SimpleSAML\Module\cmdotcom\Utils\PhoneNumber */
@@ -31,11 +32,10 @@ public static function setUpBeforeClass(): void
 
 
     /**
-     * @dataProvider validPhoneNumberProvider
-     *
      * @param string $input
      * @param string $output
      */
+    #[DataProvider('validPhoneNumberProvider')]
     public function testValidPhoneNumberIsSanitizedToE164Format(string $input, string $output): void
     {
         $result = self::$phoneNumberUtils->sanitizePhoneNumber($input);
@@ -44,10 +44,9 @@ public function testValidPhoneNumberIsSanitizedToE164Format(string $input, strin
 
 
     /**
-     * @dataProvider invalidPhoneNumberProvider
-     *
      * @param string $input
      */
+    #[DataProvider('invalidPhoneNumberProvider')]
     public function testInvalidPhoneNumberThrowsAnException(string $input): void
     {
         $this->expectException(NumberParseException::class);