Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite semi-transparent avatars over a solid background #3874

Merged
merged 8 commits into from
Aug 8, 2023
Merged

Composite semi-transparent avatars over a solid background #3874

merged 8 commits into from
Aug 8, 2023

Commits on Jul 23, 2023

  1. Composite semi-transparent avatars over a solid background

    Avatars that are semi-transparent are a problem when viewing a thread, as the line that connects different statuses in the same thread is drawn underneath the avatar and is visible.
    
    Fix this with a CompositeWithOpaqueBackground Glide transformation that:
    
    1. Extracts the alpha channel from the avatar image
    2. Converts the alpha to a 1bpp mask
    3. Draws that mask on a new bitmap, with the appropriate background colour
    4. Draws the original bitmap on top of that
    
    So any partially transparent areas of the original image are drawn over a solid background colour, so anything drawn under them will not appear.
    Nik Clayton committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    ad1aeea View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Merge remote-tracking branch 'upstream/develop' into transparent-avat…

    …ars-threads
    Nik Clayton committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    e558812 View commit details
    Browse the repository at this point in the history
  2. Only composite avatars in timelines, not elsewhere (e.g., the account…

    … page)
    Nik Clayton committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    adead8d View commit details
    Browse the repository at this point in the history
  3. Lint

    Nik Clayton committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    fb414c7 View commit details
    Browse the repository at this point in the history
  4. Merge remote-tracking branch 'upstream/develop' into transparent-avat…

    …ars-threads
    Nik Clayton committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    517d4e5 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Configuration menu
    Copy the full SHA
    c81ee8c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    28a69e0 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. Configuration menu
    Copy the full SHA
    5aa8e24 View commit details
    Browse the repository at this point in the history