-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tabs): add animation for segment #5063
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #5063 +/- ##
==========================================
- Coverage 62.38% 62.38% -0.01%
==========================================
Files 1074 1074
Lines 22586 22593 +7
Branches 5928 5930 +2
==========================================
+ Hits 14091 14095 +4
- Misses 6952 6957 +5
+ Partials 1543 1541 -2
☔ View full report in Codecov by Sentry. |
if (!tabsRailEl) return | ||
void nextTick(() => { | ||
tabsRailEl.classList.add('transition-disabled') | ||
const activeTabEl = tabsRailEl.querySelector('.n-tabs-tab--active') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way that select active tab need to be refactored, query selector is not preferred.
check refactor in b843bea |
* feat(tabs): add animation for segment * fix(tabs): fix the initialization problem * fix(tabs): fix change tabs's failure to move segment * refactor(tabs): refactor watcher to function * refactor(tabs): rename style class & remove unused class
closes #3910
Just a ugly brute force implementation, for prototyping an idea. The following things need to be checked:
Demo: