feat(tabs): add animation for segment #5063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #5063 +/- ##
==========================================
- Coverage 62.38% 62.38% -0.01%
==========================================
Files 1074 1074
Lines 22586 22593 +7
Branches 5928 5930 +2
==========================================
+ Hits 14091 14095 +4
- Misses 6952 6957 +5
+ Partials 1543 1541 -2
☔ View full report in Codecov by Sentry. |
suica
changed the title
07akioni
reviewed
Dec 20, 2023
| if (!tabsRailEl) return | ||
| void nextTick(() => { | ||
| tabsRailEl.classList.add('transition-disabled') | ||
| const activeTabEl = tabsRailEl.querySelector('.n-tabs-tab--active') |
There was a problem hiding this comment.
The way that select active tab need to be refactored, query selector is not preferred.
|
check refactor in b843bea |
liuzw2579
pushed a commit
to liuzw2579/ithinkdt-ui
that referenced
this pull request
Dec 21, 2023
* feat(tabs): add animation for segment * fix(tabs): fix the initialization problem * fix(tabs): fix change tabs's failure to move segment * refactor(tabs): refactor watcher to function * refactor(tabs): rename style class & remove unused class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3910
Just a ugly brute force implementation, for prototyping an idea. The following things need to be checked:
Demo: