Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic when double quoted strings are used for column names. #801

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

krishvishal
Copy link
Contributor

@krishvishal krishvishal commented Jan 27, 2025

Now:

limbo> create table t (a,b,c); insert into t (a,b,c) values ("hello", 234, 432);
thread 'main' panicked at core/translate/expr.rs:1621:29:
internal error: entered unreachable code: Id should be resolved to a Column before translation
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

After fix:

limbo> create table t (a,b,c); insert into t (a,b,c) values ("hello", 234, 432);

  × Parse error: no such column: "hello" - should this be a string literal in single-quotes?

limbo>

Closes #800

… statements. Double quoted strings are not supported in SQLite. Fixes tursodatabase#800
@penberg penberg merged commit 0eedea0 into tursodatabase:main Jan 28, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using double quotes on insert panics
4 participants