Refactor Json serialization to accommodate formatters for pretty printing #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreis42
approved these changes
Jan 27, 2025
core/json/ser.rs
Outdated
| } | ||
|
|
||
| /// Writes an integer value like `123` to the specified writer. | ||
|
|
There was a problem hiding this comment.
Clippy complains about empty line between comments and functions, fix this should be pretty straightforward.
There was a problem hiding this comment.
Thanks! Already made the changes.
madejejej
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Json serialization logic was pulled from serde_json. Google's json5 serialization code was not flexible enough to allow for pretty printing json, so I believe that the formatter design is a good layer to abstract this logic. This refactor will trivially enable the implementation of json_pretty function from sqlite. My other PR for json_quote, #763, depends a tiny bit on a helper utility from the previous serialization implementation. If this PR is considered first, I will change the code in my other PR to account for this.