Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up license management #677

Closed
wants to merge 4 commits into from

Conversation

seonWKim
Copy link
Contributor

@seonWKim seonWKim commented Jan 14, 2025

Purpose of this PR

  • Set up on how to manage licenses in limbo project

Changes

  • Move all licenses under licenses directory in the root path
  • Add NOTICE.md
  • Update CONTRIBUTING.md to explain how to add licenses to project

Reference

#615

@seonWKim
Copy link
Contributor Author

@LtdJorge
Copy link
Contributor

weird test failures: https://github.com/tursodatabase/limbo/actions/runs/12766122971/job/35581793173?pr=677

Sorry, fixed in #676

I had found the problem last night and wanted to push, but GitHub was down, so Pekka merged part of my PR and I think the Unix IO backend still had the problem. Linux doesn't fail because it defaults to io_uring. Maybe we should add CI checks for unix backend on Linux too?

@penberg penberg closed this in 537aea5 Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants