Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Index insert #665

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

WIP: Index insert #665

wants to merge 4 commits into from

Conversation

jussisaurio
Copy link
Collaborator

@jussisaurio jussisaurio commented Jan 13, 2025

works for trivial cases, but breaks on tree balancing. since at least @pereman2 is rewriting balancing this might be blocked until that is done?


Main changes:

  1. Add is_index to BTreeCursor
  2. Remove assumptions of there always being a rowid, use BTreeKey enum instead
  3. Add index insertion instructions and logic in insert.rs to insert to indexes if any exist
  4. Make simulator create tables with PRIMARY KEY occasionally

Change no. 4 revealed that basic index insertion works, but breaks during balancing. i didn't look at the balancing logic too much due to it being rewritten (I think), will put more effort into it when balance rewriting is done

@pereman2 FYI

Base automatically changed from remove-trait-cursor to main January 13, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant