Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: json functions vdbe code should be consistent with scalar functions #663

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jorgehermo9
Copy link

@jorgehermo9 jorgehermo9 commented Jan 12, 2025

While working to include new json functions (related to #127) I noticed that the program step code for json functions

crate::function::Func::Json(JsonFunc::Json) => {
was a bit different from scalar functions's code, where the match to the inner function is nested
crate::function::Func::Scalar(scalar_func) => match scalar_func {

I added the same nesting to the json functions so it is more consistent

@jorgehermo9 jorgehermo9 changed the title refactor: json functions vdbe refactor: json functions vdbe should be consistent with scalar functions Jan 12, 2025
@jorgehermo9 jorgehermo9 changed the title refactor: json functions vdbe should be consistent with scalar functions refactor: json functions vdbe code should be consistent with scalar functions Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant