BTree delete implementation
#661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
krishvishal
force-pushed
the
btree-delete
branch
from
a2ec67e to
b825a26
Compare
|
Added Check the SQLite docs for more info: https://www.sqlite.org/pragma.html#pragma_freelist_count |
sonhmai
reviewed
Jan 23, 2025
COMPAT.md
Outdated
| @@ -45,6 +45,7 @@ This document describes the SQLite compatibility status of Limbo: | |||
| | ON CONFLICT clause | No | | | |||
| | PRAGMA | Partial | | | |||
| | PRAGMA cache_size | Yes | | | |||
| | PRAGMA freelist_count | Yes | | | |||
There was a problem hiding this comment.
can we rebase with main and update the PRAGMA in another section?
in main we re-org the pragma statements in db3fa25
sonhmai
suggested changes
Jan 23, 2025
Comment on lines
+508
to
+513
|
|
||
| #[test] | ||
| fn test_simple_delete() -> anyhow::Result<()> { | ||
| let _ = env_logger::try_init(); | ||
| let tmp_db = TempDatabase::new("CREATE TABLE test (x INTEGER PRIMARY KEY);"); | ||
| let conn = tmp_db.connect_limbo(); |
There was a problem hiding this comment.
in main we also refactor this integration tests module a bit. can we rebase to avoid conflict here.
krishvishal
changed the title
delete implementationdelete implementation
… found`. This removes the problem with wrong cell_indices being fed to `delete()`.
…fter `if found`. This removes the problem with wrong cell_indices" This reverts commit 6d077cc.
…ntly deletes the cell we want
Now we can add dropped pages to free list, so pages can be reused in allocate_page.
… use `clear_overflow_cells` to remove any overflow pages it has and then add them to free list.
…ion is called on cell with no overflow pages.
Check SQLite docs for more info about this PRAGMA: https://www.sqlite.org/pragma.html#pragma_freelist_count
Track page fragmentation in free_cell_range. Update page offsets in drop_cell and update cell pointer array after dropping a cell.
krishvishal
force-pushed
the
btree-delete
branch
from
bced702 to
43093b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get
cell_idxfrom stack and drops the pageCurrently the
cell_idxwe are getting is wrong (1instead of0for a 1 page Btree). I suspect the problem is withseekwhich is advancing the stack's cell_indices[0] beforedeleteis called. Checktest/src/lib.rs::test_simple_delete()unit test.self.stack.advanceto afterif foundblock then delete works and test passes.@pereman2 need some guidance on this.
Core delete tasks:
Auxiliary tasks to make delete work properly:
free_cell_rangeto reduce fragmentation.free_cell_range.drop_celland update cell pointer array after dropping a cell.