Initial pass on loadable rust extensions #658
Open
+917
−511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PThorpe92
force-pushed
the
load_extensions
branch
from
7350181 to
6a046fc
Compare
PThorpe92
force-pushed
the
load_extensions
branch
from
6a046fc to
cc8092d
Compare
jussisaurio
reviewed
Jan 12, 2025
PThorpe92
force-pushed
the
load_extensions
branch
from
cc8092d to
0b91014
Compare
PThorpe92
force-pushed
the
load_extensions
branch
from
0b91014 to
3942582
Compare
PThorpe92
force-pushed
the
load_extensions
branch
from
4607985 to
13d0ab9
Compare
PThorpe92
force-pushed
the
load_extensions
branch
4 times, most recently
from
9acefb8 to
ffcbf9c
Compare
PThorpe92
force-pushed
the
load_extensions
branch
from
ffcbf9c to
6f88373
Compare
|
This likely closes #637 too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the start of an implementation of an extension library for
limboso users can write extensions in rust, that can be loaded at runtime with the.loadcli command.The existing "ExtensionFunc"
uuid, has been replaced with the first complete limbo extension inextensions/uuidThere is still considerable work to do on this, as this only implements scalar functions, but this PR is already plenty big enough.
Design + implementation comments or suggestions would be appreciated 👍
I tried out using
abi_stable, so that trait objects and other goodies could be used across FFI bounds, but to be honest I didn't find it too much better than this. I personally haven't done a whole lot with FFI, or anything at all linking dynamically in Rust, so if there is something I seem to be missing here, please let me know.I added some tests, similar to how shell-tests are setup.
If anyone can test this on other platforms, that would be helpful as well as I am limited to x86_64 linux here