Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bindings/java] Add support for limbo connection using DriverManager #646

Merged
merged 10 commits into from
Jan 14, 2025

Conversation

seonWKim
Copy link
Contributor

@seonWKim seonWKim commented Jan 10, 2025

Purpose

  • Make DriverManager aware of limbo connection

For example, we can now do as follows:

try (Connection connection = DriverManager.getConnection("jdbc:limbo:sample.db")) {
    assertThat(connection).isNotNull();
}

Changes

  • Add following .java files in order for the DriverManager to detect Limbo
    • JDBC.java
    • JDBC4Connection.java
    • LimboConfig.java
    • LimboConnection.java
    • LimboDataSource.java

Reference

@seonWKim seonWKim marked this pull request as ready for review January 13, 2025 22:35
@seonWKim seonWKim changed the title Java limbo connection bindings/java Add support for limbo connection using DriverManager Jan 14, 2025
@seonWKim seonWKim changed the title bindings/java Add support for limbo connection using DriverManager [bindings/java] Add support for limbo connection using DriverManager Jan 14, 2025
@penberg
Copy link
Collaborator

penberg commented Jan 14, 2025

@seonWKim Merging, but would actually prefer that instead of "limbo" we just use "sqlite" in the JDBC connection URL. That's because the aim here is to be compatible with SQLite so that apps don't have to care which one they're using. Having the same JDBC URL is important because it now allows applications to switch to Limbo by switching the driver but not change code or configuration.

@penberg penberg merged commit c667836 into tursodatabase:main Jan 14, 2025
37 checks passed
@seonWKim seonWKim deleted the java-limbo-connection branch January 14, 2025 08:16
penberg added a commit that referenced this pull request Jan 14, 2025
… Kim Seon Woo

## Purpose of this PR
- Add Nullability checks during compile time
## Changes
- Add `com.user.nullaway:nullaway` dependency for checking null issues
during compile time
  - Related dependencie(`com.google.errorprone`) and plugin
`net.ltgt.errorprone` is added
- Because added dependencies has Apache 2.0 License, added NOTICE.md
under the root directory.
  - Individual license for each dependency is placed under `licenses`
directory
## Note
- This PR has to be merged after
#646
## Reference
- [Issue](#615)

Closes #648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants