[pull] master from angular:master #79

…4.0.2 Fixes builds with extractLicenses enabled when using dynamic exports Fixes #22662

…t-i18n`. BREAKING CHANGE: Deprecated `ng x18n` and `ng i18n-extract` commands have been removed in favor of `ng extract-i18n`.

This is redundant since this is covered by https://github.com/angular/angular-cli/blob/e4e15058cb7a3612cb6ac31cda175783042c5a1c/packages/angular/cli/lib/cli/index.ts#L26

The currently recommended best practice for Github action workflows is to set top-level permissions to read only. And if the job uses the automatic `GITHUB_TOKEN`, fine-grained permissions for each job based on the job's requirements should also be added. All existing workflows in the repository now have top-level read only permission blocks. Only the `scorecard` workflow currently requires additional job level permissions and the minimum set of permissions were already present for the job.

…zer package This API golden file is no longer needed as the `@angular-devkit/build-optimizer` package has been removed as of v14.

The `seedrandom` dependency is not currently used within the package or project. As a result, it has been removed to prevent unneeded packages from being installed during development.

The Dockerfile at the root of the repository is both outdated (uses Node.js v10) and unused by current development processes.

7.17.3 is breaking vendor sourcemaps in windows. See: https://app.circleci.com/pipelines/github/angular/angular-cli/20692/workflows/9fc4f39e-d2f2-47c3-af01-f3a01c1bf542/jobs/288690 Related to babel/babel#14277

This is a fix to avoid hosting issues which causes bazel test to fail.

Update bazel to the latest stable version (currently 5.0.0).

The following development dependencies are no longer used directly and have been removed from the root `package.json`: * `conventional-commits-parser` * `gh-got` * `git-raw-commits`

The `common-tags` development dependency was only used in several E2E tests. Removing the usage of the dependency also allows it to be removed as a development dependency from the root `package.json`.

Updates the snapshot e2e setup to reflect the builds repository rename where `material2-builds` got renamed to `material-builds`.

…name When using the unsupported `webpackChunkName` magic comment we renamed the chunk which in some cases causes a runtime error. Closes #22525

Renovate supports use hashed version pinning for individual Github actions while still following SemVer-based tags. All workflow actions external to the Angular organization now leverage this support to ensure both that stable versions of the actions are used and that the actions are pinned to a hashed version of the tag.

Typo in underscore function code documentation.

…olve usages with Node.js builtins During the build initialization phase, many paths are converted back and forth between multiple normalized forms. These conversions involve potentially expensive string operations. The majority of the custom path `resolve` function from `@angular-devkit/core` usages have now been removed in favor of the Node.js builtin path functions. This change reduces the need to perform additional string manipulation where possible.

This file is no longer used.

…ype casting The use of the `@angular-devkit/core` `JsonObject` type is no longer needed to satisfy the type requirements of `@angular-devkit/architect` package builder creation functions.

These symbols are now exported from the primary entry-point.

…arser BREAKING CHANGE: camel case arguments are no longer allowed. Closes #13544, closes #12150, closes #22173

…rser BREAKING CHANGE: camel case arguments are no longer allowed.

Node.js v12 will become EOL on 2022-04-30. As a result, Angular as of v14 will no longer support Node.js v12.

Don't name CSS only chunks. Closes #22769

…ormat documentation The APF spec now lives in AIO.

(cherry picked from commit 3d928c0)

… seperate directory

Node.js v12 will become EOL on 2022-04-30. As a result, Angular CLI v14 will no longer support Node.js v12. BREAKING CHANGE: Support for Node.js v12 has been removed as it will become EOL on 2022-04-30. Please use Node.js v14.15 or later.

Node.js 12 is no longer supported

Version 12 is no longer supported.

With this change we refactor the Angular CLI and replace the underlying args parser and command builder. We choose to use Yargs as our parser and command builder of choice. The main advantages of Yargs over other command builders are; - Highly configurable. - We already use it in other packages such as the compiler-cli/dev-infra etc.. - Commands and options can be added during runtime. This is a requirement that is needed to support architect and schematics commands. - Outstanding documentation. - The possibility to parse args without parser configuration (Free form). - Commands are built lazily based on the arguments passed. BREAKING CHANGE: Several changes in the Angular CLI commands and arguments handling. - `ng help` has been removed in favour of the `—-help` option. - `ng —-version` has been removed in favour of `ng version` and `ng v`. - Deprecated camel cased arguments are no longer supported. Ex. using `—-sourceMap` instead of `—-source-map` will result in an error. - `ng update`, `—-migrate-only` option no longer accepts a string of migration name, instead use `—-migrate-only -—name <migration-name>`. - `—-help json` help has been removed. Closes #20976, closes #16614 and closes #16241

With this change we update yargs help method to output help in JSON format which is needed to generate the documents that are used to generate AIO man pages.

With this change we update the UA usage script to read schemas directly insteads of relying on JSON help.

…ructure

This temporary until the old command modules are removed.

…class

…provements This PR brings a number of small refactors to improve code quality in the new args parser implementation.

Previoiusly we generated the JSON help files prior to building which caused the `help` directory in the `dist` to be deleted.

…nRelativePath` Needed for consistency that will fix a Windows CI failure

Needed to fix Windows CI

The long-description.md was not referenced in `UpdateCommandModule`.

With this change we remove the JSON serialized description from the help output and also align the description properties between commands and subcommands.

BREAKING CHANGE: Support for TypeScript 4.4 and 4.5 has been removed. Please update to TypeScript 4.6.

…ics` This addresses the issue when trying to disable analytics the prompt will be shown ``` ng analytics off Would you like to share anonymous usage data about this project with the Angular Team at Google under Google’s Privacy Policy at https://policies.google.com/privacy? For more details and how to change this setting, see http://angular.io/analytics. (y/N) ``` Closes #16784 (cherry picked from commit 9a9bd3f2ac22211dc6e8a47be582c5e1390189d7)

When running architect command such as `ng build`, `ng test`, `ng lint`... and no project is provided as a positional argument. The project in the current working directory is favored instead of the configured as default project.

…CACHE` environment variable BREAKING CHANGE: `NG_BUILD_CACHE` environment variable has been removed. `cli.cache` in the workspace configuration should be used instead.

With this change we add a `--global` option to `ng analytics` command. BREAKING CHANGE: Several changes to the `ng analytics` command syntax. - `ng analytics project <setting>` has been replaced with `ng analytics <setting>` - `ng analytics <setting>` has been replaced with `ng analytics <setting> --global`

With this change we add a subcommand to `ng analytics`. This command can be used tp display analytics gathering and reporting configuration. Example: ``` $ ng analytics info Global setting: disabled Local setting: enabled Effective status: disabled ```

Re-use methods were possible.

…cs` command `ng analytics enable/disable`better aligns with `ng cache enable/disable` that will be available in the future.

…and` implementations Use the newly implemented `CommandModule` and `SchematicsCommandModule`.

This change is needed to handle default subcommands which are used in `ng generate` default subcommands are prefixed with `$0` or `*`. More info: https://github.com/yargs/yargs/blob/main/docs/advanced.md#default-commands

The `@types/node` package is now only added if E2E tests (`ng generate e2e`) or universal are added to a project.

With this change we clean up further the analytics code and re-use the `getAnalytics` to determine if the config is set or not. Also, this change inclused a refactor to the `createAnalytics` method to make it more readable.

…ot present in `schema.json` Wiht this change we show the descrption from `collection.json` if not present in schematic `schema.json` in `ng generate` help output

With this change we don't display private schematic in `ng generate` help output.

…ovided to `ng config` This fixes a regression were when no positional args are provided to `ng config` the entire config file should to be printed in the console.

…e file

With this change we create a new command `ng cache` that can be used control and check the disk cache settings. This command has 4 subcommands - `ng cache enable` which can be used to enable the cache. - `ng cache disable` which can be used to disable the cache. - `ng cache clean` which can be used to delete the cache from disk. - `ng cache info` which will print statistics and information about the cache.

…h()` Since f463c84 we use native `async`/`await` and thus we do not need to split setup in two `beforeEach()`

.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated Signed-off-by: Tobias Speicher <[email protected]>

…ject` This option is deprecated in Angular CLI and will be removed in a future major version.

…n workspace config This option is deprecated in Angular CLI and will be removed in a future major version.

With this change we deprecate the angular.json `defaultProject` option. DEPRECATED: The `defaultProject` workspace option has been deprecated. The project to use will be determined from the current working directory. Closes #20661

…s` to allow returning hidden schematics. The return value of `listSchematicNames` will include hidden schematics when is invoked with true as first parameter. By default, hidden schematics are not returned.

The `schematicCollections` can be placed under the `cli` option in the global `.angular.json` configuration, at the root or at project level in `angular.json` . ```jsonc { "$schema": "./node_modules/@angular/cli/lib/config/schema.json", "version": 1, "cli": { "schematicCollections": ["@schematics/angular", "@angular/material"] } // ... } ``` **Rationale** When this option is not configured and a user would like to run a schematic which is not part of `@schematics/angular`, the collection name needs to be provided to `ng generate` command in the form of `[collection-name:schematic-name]`. This make the `ng generate` command too verbose for repeated usages. This is where `schematicCollections` comes handle. When adding `@angular/material` to the list of `schematicCollections`, the generate command will try to locate the schematic in the specified collections. ``` ng generate navigation ``` is equivalent to: ``` ng generate @angular/material:navigation ``` **Conflicting schematic names** When multiple collections have a schematic with the same name. Both `ng generate` and `ng new` will run the first schematic matched based on the ordering (as specified) of `schematicCollections`. DEPRECATED: The `defaultCollection` workspace option has been deprecated in favor of `schematicCollections`. Before ```json "defaultCollection": "@angular/material" ``` After ```json "schematicCollections": ["@angular/material"] ``` Closes #12157

Updates the peer dependency to reflect the TS 4.6 support, avoiding warnings like: ``` warning "@angular-devkit/build-angular > @ngtools/[email protected]" has incorrect peer dependency "typescript@>=4.4.3 <4.6". ```

`inquirer` has a number of depedencies which slow down module resolution when importing (~138ms) by lazy loading this module we remove this overhead when prompts are not needed.

With this change we call the `supports` method for Yarn, NPM and PNPM asynchronous

…ata polyfill Since Angular 8, the CLI has transformed decorator metadata to a form that can be used by the Angular dependency injector without the TDZ limitations of Typescript's decorator metadata emit feature. As a result, a JIT application compiled with the CLI no longer requires the reflect metadata polyfill that was provided by `core-js`. This polyfill was also the last remaining usage of the `core-js` package within `@angular-devkit/build-angular` which allows the `core-js` package to also be removed. Refs: #14473 & angular/angular#37382 BREAKING CHANGE: Reflect metadata polyfill is no longer automatically provided in JIT mode Reflect metadata support is not required by Angular in JIT applications compiled by the CLI. Applications built in AOT mode did not and will continue to not provide the polyfill. For the majority of applications, the reflect metadata polyfill removal should have no effect. However, if an application uses JIT mode and also uses the previously polyfilled reflect metadata JavaScript APIs, the polyfill will need to be manually added to the application after updating. To replicate the previous behavior, the `core-js` package should be manually installed and the `import 'core-js/proposals/reflect-metadata';` statement should be added to the application's `polyfills.ts` file.

The `check_bazel_version` and `check_rules_nodejs_version` calls have also been removed from the WORKSPACE file as they are no longer supported or recommended by `rules_nodejs`.

The `--project_id` option was deprecated and renamed to `--bes_instance_name` in Bazel 5.0.0.

… dimension With this change we replace the custom dimension 8 `AOT Enabled`, with `Angular CLI Major Version`. The motivation behind replacing this dimension is that the there is already an `aot` dimension with id 13 which serves for the same purpose. More information to why we need a new dimension for the Angular CLI major version can be found #22130 Closes #22130

…js/json-ext` This package now ships TypeScript declaration files.

These changes include fixes to tests, timeout and stop of architect to make tests work with Jasmine 4. One noticeable change that when we didn't stop architect through `run.stop()` this causes Bazel to timeout now. Example ``` -- Test timed out at 2022-03-24 12:07:07 UTC -- /private/var/tmp/_bazel_alanagius/5168427e57f204ca069c602aa7ed1931/sandbox/darwin-sandbox/398/execroot/angular_cli/bazel-out/darwin-fastbuild/bin/packages/angular_devkit/build_angular/build_angular_browser_test.sh.runfiles/angular_cli/packages/angular_devkit/build_angular/build_angular_browser_test.sh: line 424: 41835 Terminated: 15 "${node}" ${LAUNCHER_NODE_OPTIONS[@]+"${LAUNCHER_NODE_OPTIONS[@]}"} ${USER_NODE_OPTIONS[@]+"${USER_NODE_OPTIONS[@]}"} "${MAIN}" ${ARGS[@]+"${ARGS[@]}"} 0<&0 ```

… files

With this change we clean up the package-metadata retrieval logic and types by using public `@types/` packages. Also, we lazily require `pacote` since this has a large set to dependencies which slows down module resolution.

This is no longer needed as Stackblitz implemented the missing Node.Js worker APIs.

With the rules nodejs v5 update, the symlinking default has changed from `true` to `false`. This commit explicitly adds the property and sets it to `true` similar to other Angular repositories. This helps speeding up the local DX by not having to maintain a second node modules directory.

With this change we remove the postinstall hook that was used to prompt users to confirm if they'd like to share anonymous usage with the Angular team. This post install hook was used to set the global configuration, which was mainly used for commands that run outside of a workspace such as `ng new`, `ng version` and ng `config`. We now prompt once the users runs the above mentioned commands instead of the post install.

…dating assets Currently, we are overriding asset info instead of appending additional data to it.

…ection=onPush and --style=none to generate a component

With this change we deprecate exception classes that are not used in the CLI repo. DEPRECATED: - `ContentHasMutatedException`, `InvalidUpdateRecordException`, `UnimplementedException` and `MergeConflictException` symbol from `@angular-devkit/core` have been deprecated in favor of the symbol from `@angular-devkit/schematics`. - `UnsupportedPlatformException` - A custom error exception should be created instead.

This check is no longer needed as of `0.14.29` as now esbuild correctly propagates errors. See: https://github.com/evanw/esbuild/blob/master/CHANGELOG.md#01429

removed unused parameter and improved code quality

With this change we add the angular configuration as part of the command context.

Apart from better code quality, this helps reduce the time of CLI bootstrapping time, as retrieving the package manager name is a rather expensive operator due to the number of process spawns. The package manager name isn't always needed until we run a command and therefore in some cases we can see an improvement of around `~600ms`. Ex: `ng b --help`. From ` 1.34s` to `0.76s`. This will be important when we eventually introduce auto complete as users will get faster loopback.

…udes RegExp Without the `node_modules` prefix, projects named the same as the excluded package names ex: `webpack` will not compile successfully as all files under the mentioned project will be excluded from being requested by the respective loaders. Closes #22902

This also aligns the output to have the same style of `ng add`

We already have a similar method `getProjectByCwd` that does the same thing.

…th `catch` Since this is a promise the try/catch block will not catch promise rejections which was the reason for the try/catch block.

This option is never set and doesn't provide any value, since typically when one wants to debug, you add a `debugger` statement where needed or use the `break on exception` option in the debugger.

…nfiguration Configure the `packages` positional argument to be an array instead of using `coerce` method.

…malize usage with Node.js builtins During the build initialization phase, many paths are converted back and forth between multiple normalized forms. These conversions involve potentially expensive string operations. The majority of the custom path `normalize` function from `@angular-devkit/core` usages have now been removed in favor of the Node.js builtin path functions. This change reduces the need to perform additional string manipulation where possible.

With this change we clean up repeated caching code by creating a `memoize` decorator that can be used on get accessors and methods.

…ng declaration cannot be found Due to incorrect castings previously the code would crash when the module doesn't contain an routing module with the following error: ``` Cannot read property 'properties' of undefined ``` Closes #21397

…rseJsonOptions` APIs BREAKING CHANGE: `parseJson` and `ParseJsonOptions` APIs have been removed in favor of 3rd party JSON parsers such as `jsonc-parser`.

With this change we add prompts to `ng deploy` and `ng e2e` to facilitate adding packages that offer these capabalities. We also add back `ng lint` prompt to add ESLint which was removed by mistake during the commands refactoring.

…import to es6

…scription to FileSystemEngineHost resolver The `_resolveReferenceString` abstract method of the `FileSystemEngineHostBase` class now has a third parameter that provides the collection description of the schematic currently being resolved. This allows the resolver to use any fields/options present within the collection description to adjust the resolution of the schematic. The `encapsulation` optional field is also added to the `FileSystemCollectionDescription` type which will in the future allow control of the `@angular/cli` VM context wrapping on an individual schematic collection basis.

…lt-in modules Infrastructure has been added to the schematics runtime within the `@angular/cli` package to allow schematics executed via the Angular CLI to have access upcoming built-in modules. These built-in modules will be imported/required using the `schematics:` scheme similar to the Node.js `node:` scheme available for Node.js built-in modules. No built-in modules exist yet but will be added in the future. Schematics must be executed via the Angular CLI Schematics runtime's custom VM context to use the upcoming built-in modules. All first-party Angular schematics have been executed in this manner for several major versions. Third-party schematics can now opt-in to the behavior by enabling the `encapsulation` option within a schematic collection JSON file.

With this change we add a Yargs middleware that normalizes non Array options when the argument has been provided multiple times. By default, when an option is non array and it is provided multiple times in the command line, yargs will not override it's value but instead it will be changed to an array unless `duplicate-arguments-array` is disabled. But this option also have an effect on real array options which isn't desired. See: yargs/yargs-parser#163 (comment) Closes #22956

Closes #22969

… `--verbose` option Webpack doesn't display debug logs when setting the log level to verbose. See: https://webpack.js.org/configuration/other-options/#debug and https://webpack.js.org/configuration/other-options/#level

This changes removes most of the usage of `getWorkspaceRaw` in the Angular CLI. This is needed to eventually drop the direct dependency on `jsonc-parser`.

To enable bash and zsh real-time type-ahead autocompletion, copy and paste the generated script by the `ng completion` command to your `.bashrc`, `.bash_profile`, `.zshrc` or `.zsh_profile`. Closes #11043

…sage in memoize helper This is not needed as inputs are typed checked to be `JsonValue`. With this change we get a step closer to remove `fast-json-stable-stringify` dependency.

`cli.cache` cannot be configured globally and therefore it should not be listed as part of the `validCliPaths` Map.

The `minimist` package that was previously used is no longer a dependency of the project and was only working due to package hoisting.

…riable name

With this change we replace the workspace reader and write to use `jsonc-parser` instead of our custom build JSON parser

…able-stringify` dependency This dependency is no longer needed.

… Windows The `glob`-based check when adding the sourcemap support packages to the karma setup was incorrectly skipping the files due to Windows pathing issues. The `glob`-based check, however, is unneeded due to the already present `require.resolve` checks for the sourcemap support packages which will throw if the packages are not present.

…current in optionTransforms

…from OptionTransform type

Preparation for the framework repo as outlined our planning document.

…schematics package The string helpers are predominantly used within schematics that will already depend and import from the `@angular-devkit/schematics` package. By re-exporting from `@angular-devkit/schematics`, the need to directly depend and import `@angular-devkit/core` within a schematic can be reduced and in many cases eliminated.

…ular-devkit/schematics` By using the `strings` re-export from `@angular-devkit/schematics` instead of from `@angular-devkit/core`, the number of imports from `@angular-devkit/core` has been reduced and lowers the direct dependency count for many of the individual schematics.

…vkit/core` imports Several imported types and values from `@angular-devkit/core` could be removed while still maintaining the same functionality. This further reduces the schematics direct dependence on the `@angular-devkit/core` package.

…-based application browser builder An experimental browser application builder (`browser-esbuild`) has been introduced that leverages esbuild as the bundler. This new builder is compatible with options of the current browser application builder (`browser`) and can be enabled for experimentation purposes by replacing the `builder` field of `@angular-devkit/build-angular:browser` from an existing project to `@angular-devkit/build-angular:browser-esbuild`. The builder will generate an ESM-based application and provides support for ES2015+ compatible output with ES2020 as the default. This builder is considered experimental and is not recommended for production applications. Currently not all `browser` builder options and capabilities are supported with this experimental builder. Additional support for these options may be added in the future. The following options and capabilities are not currently supported: * Stylesheet Preprocessors (only CSS styles are supported) * Angular JIT mode (only AOT is supported) * Localization [`localize`] * Watch and dev-server modes [`watch`, `poll`, etc.] * File replacements [`fileReplacements`] * License text extraction [`extractLicenses`] * Bundle budgets [`budgets`] * Global scripts [`scripts`] * Build stats JSON output [`statsJson`] * Deploy URL [`deployURL`] * CommonJS module warnings (no warnings will be generated for CommonJS package usage) * Web Workers * Service workers [`serviceWorker`, `ngswConfigPath`]

The basic suite of E2E tests are now run against the newly introduced experimental esbuild-based builder (`browser-esbuild`). Several tests are currently ignored based on the current feature set of the builder.

Webpack provides built-in support for creating hashes using the xxhash64 algorithm via a WebAssembly module. This can be significantly faster than the previously used md5 algorithm. The Webpack peer dependency has also been update to a minimum of 5.54.0 to ensure xxhash64 supported is available.

…ly from a Tree The schematics `Tree` now contains an additional `readText` method that supports directly reading the content of a file as UTF-8 text. This avoids the need to manually decode a Buffer within a schematic when text content is needed. If a file path does not exist, an exception will be thrown. While this differs from the semantics of `read`, it helps reduce the amount of code needed for common schematic use cases.

…ly from a Tree The schematics `Tree` now contains an additional `readJSON` method that supports directly reading and parsing the content of a file as UTF-8 JSON with comment support. This avoids the need to manually decode a Buffer, parse and handle JSON comments within a schematic when JSON content is needed. If a file path does not exist, an exception will be thrown. While this differs from the semantics of `read`, it helps reduce the amount of code needed for common schematic use cases. JSON parse errors will also result in an exception being thrown with a message detailing the error.

… and `readJSON` functionality Code related to decoding buffers into strings and parsing content into JSON can now be removed by using the support provided directly from the Tree instance for the executing schematic.

…worker configuration file Paths within the `angular.json` file should be relative to the location of the `angular.json` file. The `ngswConfigPath` option was incorrectly using the current working directory for a base path when a relative configuration path was specified. Most of the time this would work as a build command usually is executed from the root of the workspace. However, this may not always be the case and for those cases the actual workspace root is now used to resolve the full path for the service worker configuration file.

Adds the `--standalone` flag when generating components, directives or pipes through `ng generate`.

Updates dev-infra to the latest snapshot, supporting for the new migrate to main helper command.

[pull] master from angular:master #79

Are you sure you want to change the base?

[pull] master from angular:master #79

Commits on Feb 10, 2022

Commits on Feb 11, 2022

Commits on Feb 14, 2022

Commits on Feb 16, 2022

Commits on Feb 17, 2022

Commits on Feb 18, 2022

Commits on Feb 22, 2022

Commits on Feb 23, 2022

Commits on Feb 24, 2022

Commits on Feb 25, 2022

Commits on Mar 1, 2022

Commits on Mar 2, 2022

Commits on Mar 3, 2022

Commits on Mar 4, 2022

Commits on Mar 7, 2022

Commits on Mar 8, 2022

Commits on Mar 9, 2022

Commits on Mar 10, 2022

Commits on Mar 14, 2022

Commits on Mar 15, 2022

Commits on Mar 16, 2022

Commits on Mar 18, 2022

Commits on Mar 21, 2022

Commits on Mar 22, 2022

Commits on Mar 23, 2022

Commits on Mar 24, 2022

Commits on Mar 26, 2022

Commits on Mar 28, 2022

Commits on Mar 29, 2022

Commits on Mar 30, 2022

Commits on Mar 31, 2022

Commits on Apr 1, 2022

Commits on Apr 4, 2022

Commits on Apr 5, 2022

Commits on Apr 6, 2022

Commits on Apr 7, 2022

Commits on Apr 8, 2022

Commits on Apr 11, 2022

Commits on Apr 12, 2022

Commits on Apr 13, 2022

Commits on Apr 14, 2022

Commits on Apr 15, 2022

Commits on Apr 16, 2022

Commits on Apr 17, 2022

Commits on Apr 18, 2022

Commits on Apr 20, 2022

Commits on Apr 21, 2022

Commits on Apr 22, 2022

Commits on Apr 23, 2022

Commits on Apr 25, 2022

Commits on Apr 26, 2022

Commits on Apr 27, 2022

Commits on Apr 28, 2022