Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tuono v0.9.02 and v0.17.0 benchmarks #1

Merged
merged 8 commits into from
Jan 12, 2025

Conversation

Valerioageno
Copy link
Member

@Valerioageno Valerioageno commented Jan 11, 2025

Second step of tuono-labs/tuono#291 (comment)

I haven't followed the same exact expected folder structure:

  • apps/ is benchmarks/
  • Each benchmarks/version* folder holds its results

@Valerioageno Valerioageno self-assigned this Jan 11, 2025
@Valerioageno Valerioageno changed the title Add tuono v0.17.0 benchmarks chore: add tuono v0.17.0 benchmarks Jan 11, 2025
@marcalexiei marcalexiei changed the title chore: add tuono v0.17.0 benchmarks chore: add tuono v0.9.02 and v0.17.0 benchmarks Jan 11, 2025
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
benchmarks/v0.9.2/README.md Outdated Show resolved Hide resolved
benchmarks/v0.17.0/README.md Outdated Show resolved Hide resolved
results.json Outdated Show resolved Hide resolved
Copy link
Member

@marcalexiei marcalexiei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All proposed changes have been applied.

Additional changes to results.json:

  • benchmarks_results.*.req_per_30_secs.* changed to number from string.
  • added a JSON schema to provide validation and suggestions.
    (no CI validation has been implemented for this, let me know if you want that I think about something).

If all my changes are good for you we can merge this.

@Valerioageno Valerioageno merged commit b049291 into main Jan 12, 2025
2 checks passed
@Valerioageno Valerioageno deleted the add-benches-folder branch January 12, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants