Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: review matching and review page overhaul #243

Closed
wants to merge 9 commits into from
Closed

fix: review matching and review page overhaul #243

wants to merge 9 commits into from

Conversation

BehsadRiemer
Copy link
Collaborator

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jun 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
space ❌ Failed (Inspect) Aug 12, 2024 8:16pm

@github-actions github-actions bot added the fix label Jun 5, 2024
@BehsadRiemer BehsadRiemer added the feature New feature or request label Jun 5, 2024
BehsadRiemer
BehsadRiemer commented Jun 5, 2024
View reviewed changes
Copy link
Collaborator Author

@BehsadRiemer BehsadRiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think a drop down menu of all reviewer names would be a more suitable filter rather than manually typing in the name. Making this stateful would be really great.

BehsadRiemer
BehsadRiemer commented Jun 20, 2024
View reviewed changes
Copy link
Collaborator Author

@BehsadRiemer BehsadRiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, just seems that the feature with seeing all reviews as an admin still doesn't work properly.

app/members/columns.tsx Show resolved Hide resolved
app/opportunities/[opportunity_id]/review/page.tsx
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an admin, all reviews aren't shown :/ would be greatly appreciated if this could work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed now

@simon-hng simon-hng closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyro292 Cyro292 Cyro292 left review comments

Assignees

@Cyro292 Cyro292

Labels
feature New feature or request fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BehsadRiemer @Cyro292 @simon-hng