Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add profile editing #236

Merged
merged 9 commits into from
May 18, 2024
Merged

feat: Add profile editing #236

merged 9 commits into from
May 18, 2024

Conversation

Cyro292
Copy link
Contributor

@Cyro292 Cyro292 commented May 4, 2024

No description provided.

Copy link

vercel bot commented May 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
space ✅ Ready (Inspect) Visit Preview May 18, 2024 10:42am

@Cyro292
Copy link
Contributor Author

Cyro292 commented May 4, 2024

can someone check what went wrong with the deployment. For me it builds locally

@Cyro292 Cyro292 changed the title Feat: Add profile editing feat: Add profile editing May 6, 2024
Copy link
Collaborator

@BehsadRiemer BehsadRiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, wrote some small change requests but looking good :)

app/profile/components/ProfileOverview.tsx Outdated Show resolved Hide resolved
app/profile/components/ProfileOverview.tsx Outdated Show resolved Hide resolved
app/profile/components/ProfileOverview.tsx Outdated Show resolved Hide resolved
app/profile/components/ProfileOverview.tsx Outdated Show resolved Hide resolved
app/profile/components/ProfileOverview.tsx Outdated Show resolved Hide resolved
app/profile/components/ProfileOverview.tsx Outdated Show resolved Hide resolved
app/profile/components/ProfileOverview.tsx Show resolved Hide resolved
prisma/schema.prisma Outdated Show resolved Hide resolved
app/profile/components/ProfileOverview.tsx Show resolved Hide resolved
…olders, added abstract combobox, removed facebook from sceme
Copy link
Collaborator

@BehsadRiemer BehsadRiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, 99.9% done, just some small comment removals. I saw that the updating profiles didn't work and debugged it. See my comments, it has to do with adding the profile "id" PK to the where clause in the TRPC Mutation. Other than that really nice work 🚀

server/api/routers/profile.ts Show resolved Hide resolved
.query(async ({ input, ctx }) => {
return await ctx.db.profile.findUnique({
where: {
userId: input.userId,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

server/api/routers/profile.ts Outdated Show resolved Hide resolved
styles/globals.css Outdated Show resolved Hide resolved
lib/schemas/contact.ts Outdated Show resolved Hide resolved
server/api/routers/profile.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@BehsadRiemer BehsadRiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Let's go 💯

@BehsadRiemer BehsadRiemer merged commit 4b10a53 into dev May 18, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants