feedback, removed null-checks (bunq#93)

less complexity, risk for nullpointers is the same as before
tubbynl · Jun 18, 2018 · 20304a2 · 20304a2
1 parent aa9aae0
commit 20304a2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/main/java/com/bunq/sdk/context/UserContext.java b/src/main/java/com/bunq/sdk/context/UserContext.java
@@ -30,9 +30,9 @@ public UserContext(ApiContext apiContext) {
   }
 
   private void initUser(User user) {
-    if (user!=null && user.getUserPerson()!=null) {
+    if (user.getUserPerson()!=null) {
       this.userPerson = user.getUserPerson();
-    } else if (user!=null && user.getUserCompany()!=null) {
+    } else if (user.getUserCompany()!=null) {
       this.userCompany = user.getUserCompany();
     } else {
       throw new BunqException(ERROR_UNEXPECTED_USER_INSTANCE);

diff --git a/src/main/java/com/bunq/sdk/model/core/UserContextHelper.java b/src/main/java/com/bunq/sdk/model/core/UserContextHelper.java
@@ -28,7 +28,6 @@ public User getFirstUser() {
     BunqResponseRaw responseRaw = getRawResponse(USER_ENDPOINT_URL_LISTING);
     BunqResponse<List<User>> response = fromJsonList(User.class, responseRaw);
 
-
     return response.getValue().stream().findFirst().orElse(null);
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -28,7 +28,6 @@ public User getFirstUser() { @@
         BunqResponseRaw responseRaw = getRawResponse(USER_ENDPOINT_URL_LISTING);
         BunqResponse<List<User>> response = fromJsonList(User.class, responseRaw);
         return response.getValue().stream().findFirst().orElse(null);
       }
@@ Expand Down @@