Fix: Swap nibble order when converting to bytes

The nibble order was inverted, causing incorrect waveforms on device
tstirrat · Sep 1, 2024 · 9ffc34b · 9ffc34b
1 parent 5b24bb3
commit 9ffc34b
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/lib/sysex.ts b/src/lib/sysex.ts
@@ -15,11 +15,10 @@ export function sendWaveformSysex(port: MIDIOutput, waveform: Waveform) {
 /** Converts a waveform (32 samples) into a byte array (16 bytes) */
 export function toBytes(waveform: Waveform) {
   return waveform.reduce((bytes: number[], sample: number, index: number) => {
-    const isHighNibble = index % 2;
-    if (isHighNibble) {
-      const lowNibble = bytes[bytes.length - 1];
+    if (index % 2) {
+      const highNibble = bytes[bytes.length - 1];
 
-      const byte = lowNibble + (sample << 4);
+      const byte = sample + (highNibble << 4);
 
       bytes[bytes.length - 1] = byte;
     } else {