Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gak #514

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Improve gak #514

wants to merge 6 commits into from

Conversation

YannCabanes
Copy link
Contributor

@YannCabanes YannCabanes commented Apr 4, 2024

This pull request improves gak in which an overflow can occur when used on long almost constant time series.
This pull request is related to the issue #510 and the problem is detailed here: #510 (comment).
The current gak function always works for time series of length sz <= 204 and can fail for time series of length sz >= 205.
This pull request proposes a solution for gak to always work for time series of length sz <= 405 when the data type of the inputs is float64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant