Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][Codegen] Generate Kotlin Multiplatform bindings #3177

Draft
wants to merge 55 commits into
base: master
Choose a base branch
from
Draft

[WIP][Codegen] Generate Kotlin Multiplatform bindings #3177

wants to merge 55 commits into from

Conversation

lamafab
Copy link
Contributor

@lamafab lamafab commented May 23, 2023 •
edited
Loading

NOTE: This is WIP and marked as a draft. Do not merge yet .

About

This is the follow up to the codegen-v2 Swift binding generation (#3122) and generates Kotlin Multiplatform bindings.

Task List

Current progress:

  • (locally) Setup Kotlin Multiplatform env.
  • Remove unnecessary data from manifest.
  • Add all comments/docs from include/ to manifest.
  • Create templates and generate bindings for each platform:
    • androidMain
      • C++ generated
    • commonMain
    • ioMain
      • (2023-05-23) Started working on this
    • jsMain
  • Test all generated bindings, handle edge-cases.

lamafab added 30 commits May 11, 2023 14:19
@lamafab
init kotlin
e13ab17
@lamafab
add templte for JNI java struct/class
8f5f30b
@lamafab
add condition for is_public
8881042
@lamafab
create template for JNI java struct
32ebe1c
@lamafab
add template for andorid header file
89b0fa5
@lamafab
add template for kotlin androidmain struct
2cacb20
@lamafab
deprecate jni files
5081047
@lamafab
expand kotlin multilanguage templating, convert indices to spaces
773c504
@lamafab
add AndroidMain structures including KotlinType
717d6be
@lamafab
format and derive KotlinType
c4d364a
@lamafab
render AndroidMain inits
42fb901
@lamafab
implement process_android_main_function, add createFromNative in temp…
c5f3151 
…late
@lamafab
expand kotlin::render, process structs
420512e
@lamafab
implement render_to_strings for android main kotlin
03b058a
@lamafab
move swift tests to submodule
f997208
@lamafab
change directory structure of tests
5a18921
@lamafab
add androidmain_single_struct test
5f725eb
@lamafab
add single_class test, track output check files
e413a5b
@lamafab
add test androidmain_optional
41fb52f
@lamafab
add support for enums, add unit test
ce00966
@lamafab
test enum with descriptions
ef95109
@lamafab
set correct type for fromValue method
41fd57e
@lamafab
test enums with methods
557d6b2
@lamafab
remove static_methods field, use single methods field instead, update…
cea8e4a 
… template
@lamafab
track commom_main_struct.hbs
ed32fd1
@lamafab
start with kotlin cli command for rendering
816bccb
@lamafab
add properties to enums
be68d59
@lamafab
create primitives_android_main and primitives_common_main submodules
c0633df
@lamafab
add multiplatform structures to rendered Kotlin output
e150426
@lamafab
update output dirs in main
1b34100
@lamafab lamafab changed the title [WIP][Codegen] Codegen v2 kotlin [WIP][Codegen] Generate Kotlin Multiplatform bindings May 23, 2023
MaximPestryakov
MaximPestryakov reviewed Jun 28, 2023
View reviewed changes
codegen-v2/src/codegen/kotlin/mod.rs
impl From<TypeVariant> for KotlinType {
fn from(value: TypeVariant) -> Self {
let res = match value {
TypeVariant::Void => "Void".to_string(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TypeVariant::Void => "Void".to_string(),
TypeVariant::Void => "Unit".to_string(),

TassyBee
TassyBee reviewed Jan 6, 2024
View reviewed changes
Copy link

@TassyBee TassyBee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TassyBee TassyBee TassyBee left review comments

@MaximPestryakov MaximPestryakov MaximPestryakov left review comments

@ar-g ar-g Awaiting requested review from ar-g ar-g will be requested when the pull request is marked ready for review ar-g is a code owner

@JaimeToca JaimeToca Awaiting requested review from JaimeToca JaimeToca will be requested when the pull request is marked ready for review JaimeToca is a code owner

@rkokhatskyi rkokhatskyi Awaiting requested review from rkokhatskyi rkokhatskyi will be requested when the pull request is marked ready for review rkokhatskyi is a code owner

@Milerius Milerius Awaiting requested review from Milerius Milerius will be requested when the pull request is marked ready for review Milerius is a code owner

@satoshiotomakan satoshiotomakan Awaiting requested review from satoshiotomakan satoshiotomakan will be requested when the pull request is marked ready for review satoshiotomakan is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
codegen do not merge onhold priority:low
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lamafab @MaximPestryakov @TassyBee