Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase size of file writing #78

Closed
wants to merge 2 commits into from
Closed

Increase size of file writing #78

wants to merge 2 commits into from

Commits on Mar 1, 2023

  1. Increase size of file writing 

    The increased size of files is a requirement for  PIV,
1kB certificates are too small.
    @sosthene-nitrokey
    sosthene-nitrokey committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    ebc798f View commit details
    Browse the repository at this point in the history

  2. Remove user attributes 

    The motivation for this change is to avoid increasing the interchange size
with the larger data for files.

The justification for removing it are the following:
- They are not used anywhere
- They were actually never written, so even if someone used them they did nothing when writing
- Their usage was not documented at all
    @sosthene-nitrokey
    sosthene-nitrokey committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    14078b7 View commit details
    Browse the repository at this point in the history