Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split backend and extension #43

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

robin-nitrokey
Copy link
Member

This patch splits the trussed-auth crate into two crates: trussed-auth only defines the AuthExtension and can be used by clients or other backends implementing the extension. trussed-auth-backend contains the AuthBackend that implements the extension using the filesystem.

This patch splits the trussed-auth crate into two crates:  trussed-auth
only defines the AuthExtension and can be used by clients or other
backends implementing the extension.  trussed-auth-backend contains the
AuthBackend that implements the extension using the filesystem.
Copy link
Contributor

@sosthene-nitrokey sosthene-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be constistent with the other extensions/backends.

The implementation goes at the top level, the extension goes in to an extension top-level directory.

I fundamentally don't care much for it, but It should be consistent across crates.

@robin-nitrokey
Copy link
Member Author

I think the main difference to the other repositories is that in this case, the extension is the main component, not the backend. So what should, for example, happen with the changelog? It would be consistent to have the backend changelog in . and the extension changelog in extension, but I would find it confusing if the root changelog exists but does not contain the changes for the main crate of the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants