Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable unexpected cfg lint for cfg(loom) #20

Closed
wants to merge 1 commit into from
Closed

Disable unexpected cfg lint for cfg(loom) #20

wants to merge 1 commit into from

Conversation

robin-nitrokey
Copy link
Member

No description provided.

sosthene-nitrokey
sosthene-nitrokey requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@sosthene-nitrokey sosthene-nitrokey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if cargo made this automatic based on the presence of the [target.'cfg(loom)'.dependencies]

This PR should also fix the other new lints caught by CI.

@sosthene-nitrokey
Copy link
Contributor

Looks like they're doing the opposite of what I would have done: rust-lang/cargo#14581

@sosthene-nitrokey sosthene-nitrokey mentioned this pull request Jan 14, 2025
Open
@robin-nitrokey robin-nitrokey mentioned this pull request Jan 14, 2025
Merged
@robin-nitrokey
Copy link
Member Author

Merged in #21.

@robin-nitrokey robin-nitrokey deleted the cfg-loom branch January 14, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosthene-nitrokey sosthene-nitrokey sosthene-nitrokey requested changes

@daringer daringer Awaiting requested review from daringer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robin-nitrokey @sosthene-nitrokey